Fix various errorprone warnings and errors.

remoting/android/java/src/org/chromium/chromoting/DesktopView.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
 import android.graphics.Color;
@@ skipping 16 matching lines @@
 import org.chromium.chromoting.jni.JniInterface;
 
 /**
  * The user interface for viewing and interacting with a specific remote host.
  * It provides a canvas onto which the video feed is rendered, handles
  * multitouch pan and zoom gestures, and collects and forwards input events.
  */
 /** GUI element that holds the drawing canvas. */
 public class DesktopView extends SurfaceView implements DesktopViewInterface,
         SurfaceHolder.Callback {
-    private RenderData mRenderData;
+    private final RenderData mRenderData;
     private TouchInputHandler mInputHandler;
 
     /** The parent Desktop activity. */
     private Desktop mDesktop;
 
     // Flag to prevent multiple repaint requests from being backed up. Requests for repainting will
     // be dropped if this is already set to true. This is used by the main thread and the painting
     // thread, so the access should be synchronized on |mRenderData|.
     private boolean mRepaintPending;
 
     // Flag used to ensure that the SurfaceView is only painted between calls to surfaceCreated()
     // and surfaceDestroyed(). Accessed on main thread and display thread, so this should be
     // synchronized on |mRenderData|.
     private boolean mSurfaceCreated = false;
 
     /** Helper class for displaying the long-press feedback animation. This class is thread-safe. */
     private static class FeedbackAnimator {
         /** Total duration of the animation, in milliseconds. */
         private static final float TOTAL_DURATION_MS = 220;
 
         /** Start time of the animation, from {@link SystemClock#uptimeMillis()}. */
         private long mStartTime = 0;
 
         private boolean mRunning = false;
 
         /** Lock to allow multithreaded access to {@link #mStartTime} and {@link #mRunning}. */
-        private Object mLock = new Object();
+        private final Object mLock = new Object();
 
         private Paint mPaint = new Paint();
 
         public boolean isAnimationRunning() {
             synchronized (mLock) {
                 return mRunning;
             }
         }
 
         /**
@@ skipping 33 matching lines @@
                     new float[] {0.0f, 0.8f, 0.9f, 1.0f}, Shader.TileMode.CLAMP));
             canvas.drawCircle(x, y, radius, mPaint);
         }
     }
 
     private FeedbackAnimator mFeedbackAnimator = new FeedbackAnimator();
 
     // Variables to control animation by the TouchInputHandler.
 
     /** Protects mInputAnimationRunning. */
-    private Object mAnimationLock = new Object();
+    private final Object mAnimationLock = new Object();
 
     /** Whether the TouchInputHandler has requested animation to be performed. */
     private boolean mInputAnimationRunning = false;
 
     public DesktopView(Context context, AttributeSet attributes) {
         super(context, attributes);
 
         // Give this view keyboard focus, allowing us to customize the soft keyboard's settings.
         setFocusableInTouchMode(true);
 
@@ skipping 249 matching lines @@
     @Override
     public void setAnimationEnabled(boolean enabled) {
         synchronized (mAnimationLock) {
             if (enabled && !mInputAnimationRunning) {
                 requestRepaint();
             }
             mInputAnimationRunning = enabled;
         }
     }
 }