Fix various errorprone warnings and errors.

chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.widget;
 
 import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_PHONE;
 
 import android.animation.Animator;
 import android.animation.Animator.AnimatorListener;
@@ skipping 26 matching lines @@
 
     /**
      * Test that calling progressBar.setProgress(# > 0) followed by progressBar.setProgress(0)
      * results in a hidden progress bar.
      * @throws InterruptedException
      */
     @Feature({"Android-Toolbar"})
     @MediumTest
     @Restriction(RESTRICTION_TYPE_PHONE)
     @SuppressFBWarnings({"WA_NOT_IN_LOOP", "UW_UNCOND_WAIT"})
+    @SuppressWarnings("WaitNotInLoop")

[nyquist, 2015/08/19 09:51:33]

This seems dubious to me. Given the possible spurious wakeups, it's not
guaranteed that the wait() call will in fact ensure that the condition is
satisfied. Shouldn't we instead also set a flag in onAnimationEnd(...)? And
AtomicBoolean for example should be able to be used easily, and then in the
wait()-places, you'd add a loop to verify the state (and a timeout I guess).

[mikecase (-- gone --), 2015/08/19 23:15:08]

Done

     public void testProgressBarDisappearsAfterFastShowHide() throws InterruptedException {
         // onAnimationEnd will be signaled on progress bar showing/hiding animation end.
         final Object onAnimationEnd = new Object();
         final AtomicReference<ToolbarProgressBar> progressBar =
                 new AtomicReference<ToolbarProgressBar>();
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
             public void run() {
                 progressBar.set((ToolbarProgressBar) getActivity().findViewById(R.id.progress));
                 progressBar.get().setAlphaAnimationDuration(10);
@@ skipping 47 matching lines @@
                     progressBar.get().finish(true);
                 }
             });
 
             onAnimationEnd.wait();
             assertEquals(0.0f, progressBar.get().getAlpha());
             assertNotSame(View.VISIBLE, progressBar.get().getVisibility());
         }
     }
 }