Fix various errorprone warnings and errors.

remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.app.Activity;
 import android.graphics.Bitmap;
 import android.graphics.BitmapFactory;
 import android.graphics.PointF;
@@ skipping 165 matching lines @@
     private static final String[] SKYBOX_IMAGE_NAMES = new String[] {
         "skybox_left", "skybox_right", "skybox_bottom", "skybox_top", "skybox_back", "skybox_front"
     };
 
     private final Activity mActivity;
 
     private float mHalfDesktopWidth;
     private float mCameraPosition;
 
     // Lock to allow multithreaded access to mCameraPosition.
-    private Object mCameraPositionLock = new Object();
+    private final Object mCameraPositionLock = new Object();

[mikecase (-- gone --), 2015/08/19 23:15:08]

fyi, for lambroslambrou@chromium.org. I synced and rebased this CL and a few
additional errorprone errors popped up. Same changes as before, just made
mLoadSkyboxImagesTextureLock and mCameraPositionLock final.

[Lambros, 2015/08/19 23:42:02]

Sorry for the noise - we're actively working on this code. We'll try to avoid
non-final locks from now on :)

 
     private float[] mCameraMatrix;
     private float[] mViewMatrix;
     private float[] mProjectionMatrix;
 
     // Make matrix member variable to avoid unnecessary initialization.
     private float[] mDesktopModelMatrix;
     private float[] mDesktopCombinedMatrix;
     private float[] mEyePointModelMatrix;
     private float[] mEyePointCombinedMatrix;
@@ skipping 24 matching lines @@
     private int mSkyboxProgramHandle;
     private int mSkyboxPositionHandle;
     private int mSkyboxCombinedMatrixHandle;
     private int mSkyboxTextureUnitHandle;
     private int mSkyboxTextureDataHandle;
 
     // Flag to indicate whether reload the desktop texture or not.
     private boolean mReloadTexture;
 
     /** Lock to allow multithreaded access to mReloadTexture. */
-    private Object mReloadTextureLock = new Object();
+    private final Object mReloadTextureLock = new Object();
 
     // Lock for eye position related operations.
     // This protects access to mEyePositionVector as well as mDesktop{Height/Width}Pixels.
-    private Object mEyePositionLock = new Object();
+    private final Object mEyePositionLock = new Object();
 
     private int mDesktopHeightPixels;
     private int mDesktopWidthPixels;
 
     private FloatBuffer mDesktopCoordinates;
 
     // Flag to signal that the skybox images are fully decoded and should be loaded
     // into the OpenGL textures.
     private boolean mLoadSkyboxImagesTexture;
 
     // Lock to allow multithreaded access to mLoadSkyboxImagesTexture.
-    private Object mLoadSkyboxImagesTextureLock = new Object();
+    private final Object mLoadSkyboxImagesTextureLock = new Object();
 
     private ChromotingDownloadManager mDownloadManager;
 
     public CardboardDesktopRenderer(Activity activity) {
         mActivity = activity;
         mReloadTexture = false;
         mCameraPosition = 0.0f;
 
         mCameraMatrix = new float[16];
         mViewMatrix = new float[16];
@@ skipping 494 matching lines @@
             image.recycle();
         }
     }
 
     /**
      * Exception when BitmapFactory fails to decode file.
      */
     private static class DecodeFileException extends Exception {
     }
 }