Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove broken support for undetectable strings. Support for undetectable strings was officially dropped in https://codereview.chromium.org/916753002, but the compilers weren't fixed properly. R=yangguo@chromium.org Committed: https://crrev.com/b62dbf1efdec68ae709b0e91d3b7c13171b720c9 Cr-Commit-Position: refs/heads/master@{#30132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -73 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/code-stubs.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-12 11:36:46 UTC) #1
Benedikt Meurer
Hey Yang, As discussed offline. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-08-12 11:37:10 UTC) #2
Yang
On 2015/08/12 11:37:10, Benedikt Meurer wrote: > Hey Yang, > > As discussed offline. > ...
5 years, 4 months ago (2015-08-12 11:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287983002/1
5 years, 4 months ago (2015-08-12 11:41:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-12 12:01:27 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 12:01:53 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b62dbf1efdec68ae709b0e91d3b7c13171b720c9
Cr-Commit-Position: refs/heads/master@{#30132}

Powered by Google App Engine
This is Rietveld 408576698