Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 916753002: remove undetectable strings (Closed)

Created:
5 years, 10 months ago by dcarney
Modified:
5 years, 10 months ago
CC:
Paweł Hajdan Jr., v8-dev, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

remove undetectable strings BUG= Committed: https://crrev.com/79417664b2ef50f4224b660c5514591b1e94514f Cr-Commit-Position: refs/heads/master@{#26571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -173 lines) Patch
M include/v8.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/api.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M tools/v8heapconst.py View 3 chunks +60 lines, -62 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-11 08:59:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/916753002/1
5 years, 10 months ago (2015-02-11 08:59:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 09:28:14 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/79417664b2ef50f4224b660c5514591b1e94514f Cr-Commit-Position: refs/heads/master@{#26571}
5 years, 10 months ago (2015-02-11 09:28:26 UTC) #6
Jakob Kummerow
DBC: Why no deprecation process for this API change?
5 years, 10 months ago (2015-02-11 12:20:17 UTC) #8
dcarney
5 years, 10 months ago (2015-02-11 12:38:25 UTC) #9
Message was sent while issue was closed.
On 2015/02/11 12:20:17, Jakob wrote:
> DBC: Why no deprecation process for this API change?

it's unused, probably worldwide

Powered by Google App Engine
This is Rietveld 408576698