Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arm/lithium-codegen-arm.h" 7 #include "src/arm/lithium-codegen-arm.h"
8 #include "src/arm/lithium-gap-resolver-arm.h" 8 #include "src/arm/lithium-gap-resolver-arm.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 5634 matching lines...) Expand 10 before | Expand all | Expand 10 after
5645 Factory* factory = isolate()->factory(); 5645 Factory* factory = isolate()->factory();
5646 if (String::Equals(type_name, factory->number_string())) { 5646 if (String::Equals(type_name, factory->number_string())) {
5647 __ JumpIfSmi(input, true_label); 5647 __ JumpIfSmi(input, true_label);
5648 __ ldr(scratch, FieldMemOperand(input, HeapObject::kMapOffset)); 5648 __ ldr(scratch, FieldMemOperand(input, HeapObject::kMapOffset));
5649 __ CompareRoot(scratch, Heap::kHeapNumberMapRootIndex); 5649 __ CompareRoot(scratch, Heap::kHeapNumberMapRootIndex);
5650 final_branch_condition = eq; 5650 final_branch_condition = eq;
5651 5651
5652 } else if (String::Equals(type_name, factory->string_string())) { 5652 } else if (String::Equals(type_name, factory->string_string())) {
5653 __ JumpIfSmi(input, false_label); 5653 __ JumpIfSmi(input, false_label);
5654 __ CompareObjectType(input, scratch, no_reg, FIRST_NONSTRING_TYPE); 5654 __ CompareObjectType(input, scratch, no_reg, FIRST_NONSTRING_TYPE);
5655 __ b(ge, false_label); 5655 final_branch_condition = lt;
5656 __ ldrb(scratch, FieldMemOperand(scratch, Map::kBitFieldOffset));
5657 __ tst(scratch, Operand(1 << Map::kIsUndetectable));
5658 final_branch_condition = eq;
5659 5656
5660 } else if (String::Equals(type_name, factory->symbol_string())) { 5657 } else if (String::Equals(type_name, factory->symbol_string())) {
5661 __ JumpIfSmi(input, false_label); 5658 __ JumpIfSmi(input, false_label);
5662 __ CompareObjectType(input, scratch, no_reg, SYMBOL_TYPE); 5659 __ CompareObjectType(input, scratch, no_reg, SYMBOL_TYPE);
5663 final_branch_condition = eq; 5660 final_branch_condition = eq;
5664 5661
5665 } else if (String::Equals(type_name, factory->boolean_string())) { 5662 } else if (String::Equals(type_name, factory->boolean_string())) {
5666 __ CompareRoot(input, Heap::kTrueValueRootIndex); 5663 __ CompareRoot(input, Heap::kTrueValueRootIndex);
5667 __ b(eq, true_label); 5664 __ b(eq, true_label);
5668 __ CompareRoot(input, Heap::kFalseValueRootIndex); 5665 __ CompareRoot(input, Heap::kFalseValueRootIndex);
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
6022 __ push(ToRegister(instr->function())); 6019 __ push(ToRegister(instr->function()));
6023 CallRuntime(Runtime::kPushBlockContext, 2, instr); 6020 CallRuntime(Runtime::kPushBlockContext, 2, instr);
6024 RecordSafepoint(Safepoint::kNoLazyDeopt); 6021 RecordSafepoint(Safepoint::kNoLazyDeopt);
6025 } 6022 }
6026 6023
6027 6024
6028 #undef __ 6025 #undef __
6029 6026
6030 } // namespace internal 6027 } // namespace internal
6031 } // namespace v8 6028 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698