Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 5014 matching lines...) Expand 10 before | Expand all | Expand 10 after
5025 5025
5026 Factory* factory = isolate()->factory(); 5026 Factory* factory = isolate()->factory();
5027 if (String::Equals(check, factory->number_string())) { 5027 if (String::Equals(check, factory->number_string())) {
5028 __ JumpIfSmi(r0, if_true); 5028 __ JumpIfSmi(r0, if_true);
5029 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset)); 5029 __ ldr(r0, FieldMemOperand(r0, HeapObject::kMapOffset));
5030 __ LoadRoot(ip, Heap::kHeapNumberMapRootIndex); 5030 __ LoadRoot(ip, Heap::kHeapNumberMapRootIndex);
5031 __ cmp(r0, ip); 5031 __ cmp(r0, ip);
5032 Split(eq, if_true, if_false, fall_through); 5032 Split(eq, if_true, if_false, fall_through);
5033 } else if (String::Equals(check, factory->string_string())) { 5033 } else if (String::Equals(check, factory->string_string())) {
5034 __ JumpIfSmi(r0, if_false); 5034 __ JumpIfSmi(r0, if_false);
5035 // Check for undetectable objects => false.
5036 __ CompareObjectType(r0, r0, r1, FIRST_NONSTRING_TYPE); 5035 __ CompareObjectType(r0, r0, r1, FIRST_NONSTRING_TYPE);
5037 __ b(ge, if_false); 5036 Split(lt, if_true, if_false, fall_through);
5038 __ ldrb(r1, FieldMemOperand(r0, Map::kBitFieldOffset));
5039 __ tst(r1, Operand(1 << Map::kIsUndetectable));
5040 Split(eq, if_true, if_false, fall_through);
5041 } else if (String::Equals(check, factory->symbol_string())) { 5037 } else if (String::Equals(check, factory->symbol_string())) {
5042 __ JumpIfSmi(r0, if_false); 5038 __ JumpIfSmi(r0, if_false);
5043 __ CompareObjectType(r0, r0, r1, SYMBOL_TYPE); 5039 __ CompareObjectType(r0, r0, r1, SYMBOL_TYPE);
5044 Split(eq, if_true, if_false, fall_through); 5040 Split(eq, if_true, if_false, fall_through);
5045 } else if (String::Equals(check, factory->boolean_string())) { 5041 } else if (String::Equals(check, factory->boolean_string())) {
5046 __ CompareRoot(r0, Heap::kTrueValueRootIndex); 5042 __ CompareRoot(r0, Heap::kTrueValueRootIndex);
5047 __ b(eq, if_true); 5043 __ b(eq, if_true);
5048 __ CompareRoot(r0, Heap::kFalseValueRootIndex); 5044 __ CompareRoot(r0, Heap::kFalseValueRootIndex);
5049 Split(eq, if_true, if_false, fall_through); 5045 Split(eq, if_true, if_false, fall_through);
5050 } else if (String::Equals(check, factory->undefined_string())) { 5046 } else if (String::Equals(check, factory->undefined_string())) {
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
5444 DCHECK(interrupt_address == 5440 DCHECK(interrupt_address ==
5445 isolate->builtins()->OsrAfterStackCheck()->entry()); 5441 isolate->builtins()->OsrAfterStackCheck()->entry());
5446 return OSR_AFTER_STACK_CHECK; 5442 return OSR_AFTER_STACK_CHECK;
5447 } 5443 }
5448 5444
5449 5445
5450 } // namespace internal 5446 } // namespace internal
5451 } // namespace v8 5447 } // namespace v8
5452 5448
5453 #endif // V8_TARGET_ARCH_ARM 5449 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698