Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 5039 matching lines...) Expand 10 before | Expand all | Expand 10 after
5050 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 5050 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
5051 5051
5052 Factory* factory = isolate()->factory(); 5052 Factory* factory = isolate()->factory();
5053 if (String::Equals(check, factory->number_string())) { 5053 if (String::Equals(check, factory->number_string())) {
5054 __ JumpIfSmi(v0, if_true); 5054 __ JumpIfSmi(v0, if_true);
5055 __ lw(v0, FieldMemOperand(v0, HeapObject::kMapOffset)); 5055 __ lw(v0, FieldMemOperand(v0, HeapObject::kMapOffset));
5056 __ LoadRoot(at, Heap::kHeapNumberMapRootIndex); 5056 __ LoadRoot(at, Heap::kHeapNumberMapRootIndex);
5057 Split(eq, v0, Operand(at), if_true, if_false, fall_through); 5057 Split(eq, v0, Operand(at), if_true, if_false, fall_through);
5058 } else if (String::Equals(check, factory->string_string())) { 5058 } else if (String::Equals(check, factory->string_string())) {
5059 __ JumpIfSmi(v0, if_false); 5059 __ JumpIfSmi(v0, if_false);
5060 // Check for undetectable objects => false.
5061 __ GetObjectType(v0, v0, a1); 5060 __ GetObjectType(v0, v0, a1);
5062 __ Branch(if_false, ge, a1, Operand(FIRST_NONSTRING_TYPE)); 5061 Split(lt, a1, Operand(FIRST_NONSTRING_TYPE), if_true, if_false,
5063 __ lbu(a1, FieldMemOperand(v0, Map::kBitFieldOffset)); 5062 fall_through);
5064 __ And(a1, a1, Operand(1 << Map::kIsUndetectable));
5065 Split(eq, a1, Operand(zero_reg),
5066 if_true, if_false, fall_through);
5067 } else if (String::Equals(check, factory->symbol_string())) { 5063 } else if (String::Equals(check, factory->symbol_string())) {
5068 __ JumpIfSmi(v0, if_false); 5064 __ JumpIfSmi(v0, if_false);
5069 __ GetObjectType(v0, v0, a1); 5065 __ GetObjectType(v0, v0, a1);
5070 Split(eq, a1, Operand(SYMBOL_TYPE), if_true, if_false, fall_through); 5066 Split(eq, a1, Operand(SYMBOL_TYPE), if_true, if_false, fall_through);
5071 } else if (String::Equals(check, factory->boolean_string())) { 5067 } else if (String::Equals(check, factory->boolean_string())) {
5072 __ LoadRoot(at, Heap::kTrueValueRootIndex); 5068 __ LoadRoot(at, Heap::kTrueValueRootIndex);
5073 __ Branch(if_true, eq, v0, Operand(at)); 5069 __ Branch(if_true, eq, v0, Operand(at));
5074 __ LoadRoot(at, Heap::kFalseValueRootIndex); 5070 __ LoadRoot(at, Heap::kFalseValueRootIndex);
5075 Split(eq, v0, Operand(at), if_true, if_false, fall_through); 5071 Split(eq, v0, Operand(at), if_true, if_false, fall_through);
5076 } else if (String::Equals(check, factory->undefined_string())) { 5072 } else if (String::Equals(check, factory->undefined_string())) {
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
5406 reinterpret_cast<uint32_t>( 5402 reinterpret_cast<uint32_t>(
5407 isolate->builtins()->OsrAfterStackCheck()->entry())); 5403 isolate->builtins()->OsrAfterStackCheck()->entry()));
5408 return OSR_AFTER_STACK_CHECK; 5404 return OSR_AFTER_STACK_CHECK;
5409 } 5405 }
5410 5406
5411 5407
5412 } // namespace internal 5408 } // namespace internal
5413 } // namespace v8 5409 } // namespace v8
5414 5410
5415 #endif // V8_TARGET_ARCH_MIPS 5411 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698