src/code-stubs.h - Issue 1287983002: [compiler] Remove broken support for undetectable strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/code-stubs.h

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/code-stubs.h

diff --git a/src/code-stubs.h b/src/code-stubs.h

index f1759ee3601058c46acd9112c8dcc25efb8b67e7..68d18c7a93860f73b2679fc2c7258f657a7b8fab 100644

--- a/src/code-stubs.h

+++ b/src/code-stubs.h

@@ -2873,7 +2873,9 @@ class ToBooleanStub: public HydrogenCodeStub {

bool UpdateStatus(Handle<Object> object);

bool NeedsMap() const;

- bool CanBeUndetectable() const;

+ bool CanBeUndetectable() const {

+ return Contains(ToBooleanStub::SPEC_OBJECT);

+ }

bool IsGeneric() const { return ToIntegral() == Generic().ToIntegral(); }

static Types Generic() { return Types((1 << NUMBER_OF_TYPES) - 1); }

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/code-stubs.cc » ('j') | no next file with comments »