Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1285183010: Remove grab-bag includes of v8.h from everywhere. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from everywhere. R=bmeurer@chromium.org Committed: https://crrev.com/98a0fe0f329b4e00de826a91e192942fd0d5c0f9 Cr-Commit-Position: refs/heads/master@{#30263}

Patch Set 1 #

Patch Set 2 : Minor stylistic issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -110 lines) Patch
M src/allocation-tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/smart-pointers.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/cancelable-task.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compilation-cache.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/context-measure.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/conversions.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/counters.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/cpu-profiler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/date.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/dtoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/elements.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/extensions/trigger-failure-extension.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/fast-dtoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/fixed-dtoa.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/flags.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/global-handles.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/handles.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap-profiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap-snapshot-generator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/store-buffer-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/hydrogen-dce.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-sce.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/layout-descriptor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/lithium.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/lithium-allocator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/log-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/prettyprinter.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime-profiler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/sampler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scanner.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/scanner-character-streams.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/scanner-character-streams.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/snapshot/mksnapshot.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/snapshot/snapshot.h View 1 chunk +8 lines, -3 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/snapshot/snapshot-empty.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot/snapshot-external.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/string-search.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/strings-storage.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/transitions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/v8threads.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/version.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/version.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/gay-fixed.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/gay-precision.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/gay-shortest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/trace-extension.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1289963006 Patch 1
Issue 1300813005 Patch 1
Issue 1289963006 Patch 20001

Messages

Total messages: 8 (2 generated)
Michael Starzinger
Benedikt: PTAL. Yang: PTAL at "snapshot".
5 years, 4 months ago (2015-08-19 12:55:37 UTC) #2
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-20 05:35:07 UTC) #3
Yang
On 2015/08/20 05:35:07, Benedikt Meurer wrote: > lgtm lgtm.
5 years, 4 months ago (2015-08-20 07:00:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1285183010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1285183010/20001
5 years, 4 months ago (2015-08-20 07:42:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-20 07:44:06 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 07:44:31 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/98a0fe0f329b4e00de826a91e192942fd0d5c0f9
Cr-Commit-Position: refs/heads/master@{#30263}

Powered by Google App Engine
This is Rietveld 408576698