Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/version.cc

Issue 1285183010: Remove grab-bag includes of v8.h from everywhere. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Minor stylistic issue. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/version.h ('k') | test/cctest/cctest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/version.h"
6
5 #include "include/v8-version.h" 7 #include "include/v8-version.h"
6 #include "src/v8.h" 8 #include "src/utils.h"
7 #include "src/version.h"
8 9
9 // Define SONAME to have the build system put a specific SONAME into the 10 // Define SONAME to have the build system put a specific SONAME into the
10 // shared library instead the generic SONAME generated from the V8 version 11 // shared library instead the generic SONAME generated from the V8 version
11 // number. This define is mainly used by the build system script. 12 // number. This define is mainly used by the build system script.
12 #define SONAME "" 13 #define SONAME ""
13 14
14 #if V8_IS_CANDIDATE_VERSION 15 #if V8_IS_CANDIDATE_VERSION
15 #define CANDIDATE_STRING " (candidate)" 16 #define CANDIDATE_STRING " (candidate)"
16 #else 17 #else
17 #define CANDIDATE_STRING "" 18 #define CANDIDATE_STRING ""
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 GetMajor(), GetMinor(), GetBuild(), candidate); 75 GetMajor(), GetMinor(), GetBuild(), candidate);
75 } 76 }
76 } else { 77 } else {
77 // Use specific SONAME. 78 // Use specific SONAME.
78 SNPrintF(str, "%s", soname_); 79 SNPrintF(str, "%s", soname_);
79 } 80 }
80 } 81 }
81 82
82 } // namespace internal 83 } // namespace internal
83 } // namespace v8 84 } // namespace v8
OLDNEW
« no previous file with comments | « src/version.h ('k') | test/cctest/cctest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698