Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1289963006: [heap] Remove obsolete Heap::sweep_generation field. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-everywhere
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove obsolete Heap::sweep_generation field. R=mlippautz@chromium.org Committed: https://crrev.com/373c0b511aa065493b41a5f5dcb289f613cdfc45 Cr-Commit-Position: refs/heads/master@{#30253}

Patch Set 1 #

Patch Set 2 : Fix Windows compilation. #

Patch Set 3 : Drop bogus dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M src/heap/heap.h View 1 3 chunks +1 line, -7 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-19 14:13:17 UTC) #1
Michael Lippautz
lgtm % compilation errors
5 years, 4 months ago (2015-08-19 14:21:09 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1285183010 Patch 20001). Please resolve the dependency and ...
5 years, 4 months ago (2015-08-19 15:19:47 UTC) #6
Michael Starzinger
Well, thank you CQ, but no thank you.
5 years, 4 months ago (2015-08-19 15:21:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289963006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289963006/40001
5 years, 4 months ago (2015-08-19 15:21:45 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-19 16:09:47 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:10:07 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/373c0b511aa065493b41a5f5dcb289f613cdfc45
Cr-Commit-Position: refs/heads/master@{#30253}

Powered by Google App Engine
This is Rietveld 408576698