[Interpreter] Add implementations of arithmetic binary op bytecodes.

[Interpreter] Add implementations of arithmetic binary op bytecodes.

Adds implementations and tests for the following bytecodes:
  - Add
  - Sub
  - Mul
  - Div
  - Mod

Also adds the Mod bytecode and adds support to BytecodeGenerator and
BytecodeArrayBuilder to enable it's use.

The current bytecodes always call through to the JS builtins. This also adds
LoadObjectField and CallJSBuiltin operators to the InterpreterAssembler.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/b5502099b7ff9d1f77d28c3ec26f2b40383d1492
Cr-Commit-Position: refs/heads/master@{#30352}

[rmcilroy, 2015-08-19 14:32:15]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-19 14:32:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300813005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300813005/1

[rmcilroy, 2015-08-19 14:33:21]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org

[rmcilroy, 2015-08-19 14:33:21]

Michael / Orion, could you please take a look, thanks.

[commit-bot: I haz the power, 2015-08-19 14:33:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 14:33:46]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/8722)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8825)

[Michael Starzinger, 2015-08-19 17:18:57]

Looking good, just comments about the new RawMachineAssembler::CallJS ...

https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.cc (right):

https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.cc:225: return CallJSBuiltin(builtin,
receiver, args, 1);
nit: Shouldn't the following do the trick ...

return CallJSBuiltin(builtin, receiver, &arg1, 1);

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.cc (right):

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:146: buffer[index++] = graph()->start();
Please don't add effect and control inputs to the call in the raw machine
assembler.

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:148: CallDescriptor* descriptor =
Linkage::GetJSCallDescriptor(
Would it be possible to just use RawMachineAssembler::CallN instead and move
computation of the call-descriptor to the caller (i.e. into
InterpreterAssembler) instead?

[rmcilroy, 2015-08-24 11:49:07]

Comments addressed, PTAL.

https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-as...
File src/compiler/interpreter-assembler.cc (right):

https://codereview.chromium.org/1300813005/diff/1/src/compiler/interpreter-as...
src/compiler/interpreter-assembler.cc:225: return CallJSBuiltin(builtin,
receiver, args, 1);
On 2015/08/19 17:18:56, Michael Starzinger wrote:
> nit: Shouldn't the following do the trick ...
> 
> return CallJSBuiltin(builtin, receiver, &arg1, 1);

Yup :). Done.

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.cc (right):

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:146: buffer[index++] = graph()->start();
On 2015/08/19 17:18:56, Michael Starzinger wrote:
> Please don't add effect and control inputs to the call in the raw machine
> assembler.

As discussed in https://codereview.chromium.org/1283193007/, there are various
reasons why we want to do this.

https://codereview.chromium.org/1300813005/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:148: CallDescriptor* descriptor =
Linkage::GetJSCallDescriptor(
On 2015/08/19 17:18:56, Michael Starzinger wrote:
> Would it be possible to just use RawMachineAssembler::CallN instead and move
> computation of the call-descriptor to the caller (i.e. into
> InterpreterAssembler) instead?

Done (also removed CallJs0 and renamed CallInterpreterDispatch -> TailCallN.

[Michael Starzinger, 2015-08-24 14:06:06]

LGTM. Thanks.

[rmcilroy, 2015-08-24 14:16:14]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-08-24 14:16:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300813005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300813005/20001

[commit-bot: I haz the power, 2015-08-24 14:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 14:17:41]

Try jobs failed on following builders:
  v8_win_compile_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/6916)
  v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)

[rmcilroy, 2015-08-25 07:40:04]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-25 07:40:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1300813005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-08-25 07:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300813005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300813005/40001

[commit-bot: I haz the power, 2015-08-25 08:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 08:22:51]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/7956)

[rmcilroy, 2015-08-25 10:47:01]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-25 10:47:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1300813005/#ps60001
(title: "Fix passing wrong context to JS builtin")

[commit-bot: I haz the power, 2015-08-25 10:47:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300813005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300813005/60001

[commit-bot: I haz the power, 2015-08-25 10:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 10:56:50]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[rmcilroy, 2015-08-25 11:07:04]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-25 11:07:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1300813005/#ps80001
(title: "Fix unittest too...")

[commit-bot: I haz the power, 2015-08-25 11:07:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1300813005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1300813005/80001

[commit-bot: I haz the power, 2015-08-25 11:31:14]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-25 11:31:26]

Patchset 5 (id:??) landed as
https://crrev.com/b5502099b7ff9d1f77d28c3ec26f2b40383d1492
Cr-Commit-Position: refs/heads/master@{#30352}