Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/version.h

Issue 1285183010: Remove grab-bag includes of v8.h from everywhere. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Minor stylistic issue. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/v8threads.cc ('k') | src/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_VERSION_H_ 5 #ifndef V8_VERSION_H_
6 #define V8_VERSION_H_ 6 #define V8_VERSION_H_
7 7
8 #include "src/base/functional.h" 8 #include "src/base/functional.h"
9 #include "src/vector.h"
9 10
10 namespace v8 { 11 namespace v8 {
11 namespace internal { 12 namespace internal {
12 13
13 class Version { 14 class Version {
14 public: 15 public:
15 // Return the various version components. 16 // Return the various version components.
16 static int GetMajor() { return major_; } 17 static int GetMajor() { return major_; }
17 static int GetMinor() { return minor_; } 18 static int GetMinor() { return minor_; }
18 static int GetBuild() { return build_; } 19 static int GetBuild() { return build_; }
(...skipping 23 matching lines...) Expand all
42 static const char* version_string_; 43 static const char* version_string_;
43 44
44 // In test-version.cc. 45 // In test-version.cc.
45 friend void SetVersion(int major, int minor, int build, int patch, 46 friend void SetVersion(int major, int minor, int build, int patch,
46 bool candidate, const char* soname); 47 bool candidate, const char* soname);
47 }; 48 };
48 49
49 } } // namespace v8::internal 50 } } // namespace v8::internal
50 51
51 #endif // V8_VERSION_H_ 52 #endif // V8_VERSION_H_
OLDNEW
« no previous file with comments | « src/v8threads.cc ('k') | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698