Remove remaining legacy SplitString calls.

Remove remaining legacy SplitString calls.

TBR=zelidrag@chromium.org (chromeos)

Committed: https://crrev.com/83dc1610d1a0e3b78909b565943bfa12aeae9370
Cr-Commit-Position: refs/heads/master@{#342983}

[brettw, 2015-08-11 21:21:57]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2015-08-11 21:22:08]

The last of the Split string patches!

[brettw, 2015-08-11 21:22:13]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 21:22:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/20001

[commit-bot: I haz the power, 2015-08-11 21:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 21:35:54]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-08-11 21:39:38]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-11 21:39:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/60001

[sky, 2015-08-11 21:48:51]

LGTM

Personally I think code like this:
 for (const auto& netif : base::SplitString(
is hard to follow because you have to look at SplitString to find what |netif|
is. I prefer the explicit type. I leave it to you if you want to convert the
places I mentioned. There are a couple of more I didn't comment on.

https://codereview.chromium.org/1284833004/diff/60001/chromecast/net/net_util...
File chromecast/net/net_util_cast.cc (right):

https://codereview.chromium.org/1284833004/diff/60001/chromecast/net/net_util...
chromecast/net/net_util_cast.cc:25: for (const auto& netif : base::SplitString(
nit: auto->std::string as it isn't much longer and helps readability.

https://codereview.chromium.org/1284833004/diff/60001/tools/android/memdump/m...
File tools/android/memdump/memdump.cc (right):

https://codereview.chromium.org/1284833004/diff/60001/tools/android/memdump/m...
tools/android/memdump/memdump.cc:133: tokens = base::SplitString(
*tokens

https://codereview.chromium.org/1284833004/diff/60001/tools/gn/command_refs.cc
File tools/gn/command_refs.cc (right):

https://codereview.chromium.org/1284833004/diff/60001/tools/gn/command_refs.c...
tools/gn/command_refs.cc:418: for (const auto& line : base::SplitString(
nit: auto->std::string (or StringPiece)

[commit-bot: I haz the power, 2015-08-11 21:53:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 21:53:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-08-11 23:23:05]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-11 23:23:05]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1284833004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-11 23:23:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/80001

[commit-bot: I haz the power, 2015-08-11 23:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 23:36:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2015-08-11 23:41:59]

brettw@chromium.org changed reviewers:
+ zelidrag@chromium.org

[brettw, 2015-08-11 23:43:02]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-11 23:43:02]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1284833004/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-08-11 23:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/100001

[commit-bot: I haz the power, 2015-08-12 00:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 00:21:51]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[brettw, 2015-08-12 04:31:31]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-12 04:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1284833004/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-08-12 04:31:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/120001

[commit-bot: I haz the power, 2015-08-12 05:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 05:21:26]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brettw, 2015-08-12 06:01:13]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-08-12 06:01:13]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1284833004/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-08-12 06:01:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1284833004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1284833004/140001

[commit-bot: I haz the power, 2015-08-12 07:31:25]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-08-12 07:32:04]

Patchset 8 (id:??) landed as
https://crrev.com/83dc1610d1a0e3b78909b565943bfa12aeae9370
Cr-Commit-Position: refs/heads/master@{#342983}

[kmackay, 2015-08-12 20:24:16]

BTW you didn't remove the old SplitStr(str, c, result) implementations from
string_split.cc; not sure if that was intentional.

[kmackay, 2015-08-12 20:25:24]

On 2015/08/12 20:24:16, kmackay wrote:
> BTW you didn't remove the old SplitStr(str, c, result) implementations from
> string_split.cc; not sure if that was intentional.

I meant SplitString(str, c, result)

[brettw, 2015-08-12 20:54:03]

Thanks for noticing, will do it.