sql/connection.cc - Issue 1284833004: Remove remaining legacy SplitString calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sql/connection.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sql/connection.cc

diff --git a/sql/connection.cc b/sql/connection.cc

index d07d425eb1721ac5b1da4c78198caac030fd4744..0cb3b131bcc42ce7c1176b6807daa50e57025cf6 100644

--- a/sql/connection.cc

+++ b/sql/connection.cc

@@ -1327,7 +1327,8 @@ bool Connection::IntegrityCheckHelper(

// it could return separate lines, so loop _and_ split.

while (stmt.Step()) {

std::string result(stmt.ColumnString(0));

- base::SplitString(result, '\n', messages);

+ *messages = base::SplitString(result, "\n", base::TRIM_WHITESPACE,

+ base::SPLIT_WANT_ALL);

}

ret = stmt.Succeeded();

}