skia/ext/image_operations_bench.cc - Issue 1284833004: Remove remaining legacy SplitString calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/image_operations_bench.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/image_operations_bench.cc

diff --git a/skia/ext/image_operations_bench.cc b/skia/ext/image_operations_bench.cc

index b5464c64d37f712f80d5894bfb70d842d34fb516..9b2667fec35dcd223e52c0ed20ca4d30bc27db78 100644

--- a/skia/ext/image_operations_bench.cc

+++ b/skia/ext/image_operations_bench.cc

@@ -119,8 +119,8 @@ class Dimensions {

// On failure, will set its state in such a way that IsValid will return

// false.

void FromString(const std::string& arg) {

- std::vector<std::string> strings;

- base::SplitString(std::string(arg), 'x', &strings);

+ std::vector<base::StringPiece> strings = base::SplitStringPiece(

+ arg, "x", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

if (strings.size() != 2 ||

base::StringToInt(strings[0], &width_) == false ||

base::StringToInt(strings[1], &height_) == false) {

« no previous file with comments | « sandbox/win/src/named_pipe_dispatcher.cc ('k') | sql/connection.cc » ('j') | no next file with comments »