Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chromeos/dbus/dbus_client_bundle.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/net/net_util_cast.cc ('k') | chromeos/network/network_change_notifier_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/dbus_client_bundle.cc
diff --git a/chromeos/dbus/dbus_client_bundle.cc b/chromeos/dbus/dbus_client_bundle.cc
index 89ac43604946f23d20307a5ce79caa742805a6fd..20b0898c7ead909fc4b26764ea3d15263b04724c 100644
--- a/chromeos/dbus/dbus_client_bundle.cc
+++ b/chromeos/dbus/dbus_client_bundle.cc
@@ -354,17 +354,14 @@ void DBusClientBundle::SetupDefaultEnvironment() {
DBusClientBundle::DBusClientTypeMask DBusClientBundle::ParseUnstubList(
const std::string& unstub_list) {
DBusClientTypeMask unstub_mask = 0;
- std::vector<std::string> unstub_components;
- base::SplitString(unstub_list, ',', &unstub_components);
- for (std::vector<std::string>::const_iterator iter =
- unstub_components.begin();
- iter != unstub_components.end(); ++iter) {
- DBusClientBundle::DBusClientType client = GetDBusClientType(*iter);
+ for (const std::string& cur : base::SplitString(
+ unstub_list, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ DBusClientBundle::DBusClientType client = GetDBusClientType(cur);
if (client != NO_CLIENT) {
- LOG(WARNING) << "Unstubbing dbus client for " << *iter;
+ LOG(WARNING) << "Unstubbing dbus client for " << cur;
unstub_mask |= client;
} else {
- LOG(ERROR) << "Unknown dbus client: " << *iter;
+ LOG(ERROR) << "Unknown dbus client: " << cur;
}
}
« no previous file with comments | « chromecast/net/net_util_cast.cc ('k') | chromeos/network/network_change_notifier_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698