gin/modules/file_module_provider.cc - Issue 1284833004: Remove remaining legacy SplitString calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/file_module_provider.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/file_module_provider.cc

diff --git a/gin/modules/file_module_provider.cc b/gin/modules/file_module_provider.cc

index b8465ae6368ba61f38045feb04d3f82d96632266..1568378ee604240cfb1a144fe772c89b59fc0d07 100644

--- a/gin/modules/file_module_provider.cc

+++ b/gin/modules/file_module_provider.cc

@@ -20,8 +20,8 @@ void AttempToLoadModule(const base::WeakPtr<Runner>& runner,

if (!runner)

return;

- std::vector<std::string> components;

- base::SplitString(id, '/', &components);

+ std::vector<std::string> components = base::SplitString(

+ id, "/", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);

base::FilePath path;

for (size_t i = 0; i < components.size(); ++i) {