Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5391)

Unified Diff: chromeos/network/network_change_notifier_chromeos_unittest.cc

Issue 1284833004: Remove remaining legacy SplitString calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/system/version_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_change_notifier_chromeos_unittest.cc
diff --git a/chromeos/network/network_change_notifier_chromeos_unittest.cc b/chromeos/network/network_change_notifier_chromeos_unittest.cc
index ffbe7c740e2547488def7becc258e405351143ad..570bc36627afd4af61c93a4dfb37290672a62b80 100644
--- a/chromeos/network/network_change_notifier_chromeos_unittest.cc
+++ b/chromeos/network/network_change_notifier_chromeos_unittest.cc
@@ -127,8 +127,9 @@ class NetworkChangeNotifierChromeosUpdateTest : public testing::Test {
notifier_.service_path_ = notifier_state.service_path;
notifier_.ip_address_ = notifier_state.ip_address;
notifier_.max_bandwidth_mbps_ = notifier_state.max_bandwidth;
- std::vector<std::string> dns_servers;
- base::SplitString(notifier_state.dns_servers, ',', &dns_servers);
+ std::vector<std::string> dns_servers =
+ base::SplitString(notifier_state.dns_servers, ",",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
notifier_.dns_servers_ = dns_servers;
}
@@ -137,8 +138,9 @@ class NetworkChangeNotifierChromeosUpdateTest : public testing::Test {
EXPECT_EQ(notifier_state.service_path, notifier_.service_path_);
EXPECT_EQ(notifier_state.ip_address, notifier_.ip_address_);
EXPECT_EQ(notifier_state.max_bandwidth, notifier_.max_bandwidth_mbps_);
- std::vector<std::string> dns_servers;
- base::SplitString(notifier_state.dns_servers, ',', &dns_servers);
+ std::vector<std::string> dns_servers =
+ base::SplitString(notifier_state.dns_servers, ",",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
EXPECT_EQ(dns_servers, notifier_.dns_servers_);
}
@@ -155,8 +157,9 @@ class NetworkChangeNotifierChromeosUpdateTest : public testing::Test {
default_network_state.network_technology;
default_network_.path_ = default_network_state.service_path;
default_network_.ip_address_ = default_network_state.ip_address;
- std::vector<std::string> dns_servers;
- base::SplitString(default_network_state.dns_servers, ',', &dns_servers);
+ std::vector<std::string> dns_servers =
+ base::SplitString(default_network_state.dns_servers, ",",
+ base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
default_network_.dns_servers_ = dns_servers;
}
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/system/version_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698