|
Fix crash caused by concurrent access to framebuffer_combo_complete_map_.
The current implementation of framebuffer completeness testing uses a single global hash_map as a cache. This leads to races in WebView when GPU and render threads try to access the cache concurrently.
BUG= 518858
Committed: https://crrev.com/fc199b47cb5b74c9f2ccf3a6316fc9b7009c6904
Cr-Commit-Position: refs/heads/master@{#344940}
Total comments: 12
Total comments: 17
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+209 lines, -141 lines) |
Patch |
 |
M |
android_webview/browser/deferred_gpu_command_service.h
|
View
|
1
2
3
4
5
6
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
android_webview/browser/deferred_gpu_command_service.cc
|
View
|
1
2
3
4
5
6
7
8
|
2 chunks |
+10 lines, -0 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_driver.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
components/view_manager/gles2/command_buffer_local.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/gpu_channel_manager.h
|
View
|
1
2
3
4
5
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/gpu_channel_manager.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/common/gpu/gpu_command_buffer_stub.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/BUILD.gn
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/context_group.h
|
View
|
1
2
3
4
5
|
4 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/context_group.cc
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+16 lines, -2 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/context_group_unittest.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A |
gpu/command_buffer/service/framebuffer_completeness_cache.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
A |
gpu/command_buffer/service/framebuffer_completeness_cache.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/framebuffer_manager.h
|
View
|
1
2
3
4
5
8
|
6 chunks |
+12 lines, -14 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/framebuffer_manager.cc
|
View
|
1
2
3
4
5
6
7
8
|
5 chunks |
+32 lines, -53 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/framebuffer_manager_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
8 chunks |
+5 lines, -32 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+3 lines, -8 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/in_process_command_buffer.h
|
View
|
1
2
3
4
5
|
4 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/in_process_command_buffer.cc
|
View
|
1
2
3
4
5
|
2 chunks |
+11 lines, -4 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/service/texture_manager_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer/tests/gl_manager.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+4 lines, -8 lines |
0 comments
|
Download
|
 |
M |
gpu/command_buffer_service.gypi
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
gpu/gles2_conform_support/egl/display.cc
|
View
|
1
2
3
4
5
|
1 chunk |
+3 lines, -8 lines |
0 comments
|
Download
|
Total messages: 37 (8 generated)
|