Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: gpu/command_buffer/service/framebuffer_completeness_cache.h

Issue 1278333003: Fix crash caused by concurrent access to framebuffer_combo_complete_map_. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments; return unittesting of cache behaviour. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_COMPLETENESS_CACHE_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_COMPLETENESS_CACHE_H_
7
8 #include "base/containers/hash_tables.h"
9 #include "base/memory/ref_counted.h"
10 #include "gpu/gpu_export.h"
11
12 namespace gpu {
13 namespace gles2 {
14
15 // Refcounted wrapper for a hash_set of framebuffer format signatures
16 // representing [XXX]
Ken Russell (switch to Gerrit) 2015/08/20 00:04:10 Incomplete comment?
Tobias Sargeant 2015/08/20 11:05:13 Yep. Oops.
17 class GPU_EXPORT FramebufferCompletenessCache
18 : public base::RefCounted<FramebufferCompletenessCache> {
19 public:
20 FramebufferCompletenessCache();
21
22 bool IsComplete(const std::string& signature) const;
23 void SetComplete(const std::string& signature);
24
25 protected:
26 virtual ~FramebufferCompletenessCache();
27
28 private:
29 friend class base::RefCounted<FramebufferCompletenessCache>;
30
31 typedef base::hash_set<std::string> Map;
32
33 Map cache_;
34
35 DISALLOW_COPY_AND_ASSIGN(FramebufferCompletenessCache);
36 };
37
38 } // namespace gles2
39 } // namespace gpu
40
41 #endif // GPU_COMMAND_BUFFER_COMMON_FRAMEBUFFER_COMPLETENESS_CACHE_H_
no sievers 2015/08/19 23:39:47 nit: _COMMON_ -> _SERVICE_
Tobias Sargeant 2015/08/20 11:05:13 Done.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698