Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr., rossberg, bbudge
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. There's no need to have one InstanceType per SIMD primitive type (this will not scale long-term). Also reduce the amount of code duplication and make it more robust wrt adding new SIMD types. R=yangguo@chromium.org Committed: https://crrev.com/f4c079d450a5990639b295d40a3d1663d70412d6 Cr-Commit-Position: refs/heads/master@{#30107}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix slow check failures. REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -844 lines) Patch
M include/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +11 lines, -39 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +14 lines, -67 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +14 lines, -17 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 3 chunks +12 lines, -35 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 4 chunks +14 lines, -45 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 3 chunks +12 lines, -34 lines 0 comments Download
M src/heap/heap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +26 lines, -29 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -19 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +11 lines, -14 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +11 lines, -39 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +7 lines, -14 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +13 lines, -19 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +13 lines, -52 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 3 chunks +16 lines, -54 lines 0 comments Download
M src/objects.h View 5 chunks +29 lines, -41 lines 0 comments Download
M src/objects.cc View 2 chunks +11 lines, -27 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +3 lines, -39 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +9 lines, -15 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +11 lines, -20 lines 0 comments Download
M src/runtime/runtime-simd.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/type-info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/types.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +11 lines, -39 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-11 08:51:04 UTC) #1
Benedikt Meurer
Hey Yang, This reduces the number of instance types for SIMD primitives to 1 again ...
5 years, 4 months ago (2015-08-11 08:52:42 UTC) #2
Yang
On 2015/08/11 08:52:42, Benedikt Meurer wrote: > Hey Yang, > > This reduces the number ...
5 years, 4 months ago (2015-08-11 09:08:35 UTC) #3
Yang
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc#newcode402 src/code-stubs-hydrogen.cc:402: is_float32x4.If<HCompareObjectEqAndBranch>( Can we do an instance type check first ...
5 years, 4 months ago (2015-08-11 09:08:46 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/1273353003/diff/1/src/code-stubs-hydrogen.cc#newcode402 src/code-stubs-hydrogen.cc:402: is_float32x4.If<HCompareObjectEqAndBranch>( As discussed offline: There's no runtime fallback (yet). ...
5 years, 4 months ago (2015-08-11 09:11:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273353003/1
5 years, 4 months ago (2015-08-11 09:12:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1273353003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1273353003/20001
5 years, 4 months ago (2015-08-11 09:19:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 09:45:31 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 09:45:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4c079d450a5990639b295d40a3d1663d70412d6
Cr-Commit-Position: refs/heads/master@{#30107}

Powered by Google App Engine
This is Rietveld 408576698