Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/mips64/full-codegen-mips64.cc
diff --git a/src/full-codegen/mips64/full-codegen-mips64.cc b/src/full-codegen/mips64/full-codegen-mips64.cc
index 2f3f11502da024ddd2c4e8e02b69f19a8f7d48aa..7666be76f45985e50a9177e25c45c8c999bb5b14 100644
--- a/src/full-codegen/mips64/full-codegen-mips64.cc
+++ b/src/full-codegen/mips64/full-codegen-mips64.cc
@@ -3433,13 +3433,9 @@ void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
&if_false, &fall_through);
__ JumpIfSmi(v0, if_false);
- Register map = a1;
- Register type_reg = a2;
- __ GetObjectType(v0, map, type_reg);
- __ Subu(type_reg, type_reg, Operand(FIRST_SIMD_VALUE_TYPE));
+ __ GetObjectType(v0, a1, a1);
PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
- Split(ls, type_reg, Operand(LAST_SIMD_VALUE_TYPE - FIRST_SIMD_VALUE_TYPE),
- if_true, if_false, fall_through);
+ Split(eq, a1, Operand(SIMD128_VALUE_TYPE), if_true, if_false, fall_through);
context()->Plug(if_true, if_false);
}
@@ -5074,34 +5070,6 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
__ JumpIfSmi(v0, if_false);
__ GetObjectType(v0, v0, a1);
Split(eq, a1, Operand(SYMBOL_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->float32x4_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(FLOAT32X4_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int32x4_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(INT32X4_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool32x4_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(BOOL32X4_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int16x8_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(INT16X8_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool16x8_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(BOOL16X8_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int8x16_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(INT8X16_TYPE), if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool8x16_string())) {
- __ JumpIfSmi(v0, if_false);
- __ GetObjectType(v0, v0, a1);
- Split(eq, a1, Operand(BOOL8X16_TYPE), if_true, if_false, fall_through);
} else if (String::Equals(check, factory->boolean_string())) {
__ LoadRoot(at, Heap::kTrueValueRootIndex);
__ Branch(if_true, eq, v0, Operand(at));
@@ -5136,6 +5104,16 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
__ lbu(a1, FieldMemOperand(v0, Map::kBitFieldOffset));
__ And(a1, a1, Operand(1 << Map::kIsUndetectable));
Split(eq, a1, Operand(zero_reg), if_true, if_false, fall_through);
+// clang-format off
+#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
+ } else if (String::Equals(check, factory->type##_string())) { \
+ __ JumpIfSmi(v0, if_false); \
+ __ ld(v0, FieldMemOperand(v0, HeapObject::kMapOffset)); \
+ __ LoadRoot(at, Heap::k##Type##MapRootIndex); \
+ Split(eq, v0, Operand(at), if_true, if_false, fall_through);
+ SIMD128_TYPES(SIMD128_TYPE)
+#undef SIMD128_TYPE
+ // clang-format on
} else {
if (if_false != fall_through) __ jmp(if_false);
}
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698