Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: src/objects.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 658c0d78b68d8fe889ceff508bb59592cb8a6971..812a021adb8446e61f246033dc1e4b47d0186745 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1405,27 +1405,17 @@ void HeapObject::HeapObjectShortPrint(std::ostream& os) { // NOLINT
os << '>';
break;
}
- case FLOAT32X4_TYPE:
- os << "<Float32x4>";
- break;
- case INT32X4_TYPE:
- os << "<Int32x4>";
- break;
- case BOOL32X4_TYPE:
- os << "<Bool32x4>";
- break;
- case INT16X8_TYPE:
- os << "<Int16x8>";
- break;
- case BOOL16X8_TYPE:
- os << "<Bool16x8>";
- break;
- case INT8X16_TYPE:
- os << "<Int8x16>";
- break;
- case BOOL8X16_TYPE:
- os << "<Bool8x16>";
+ case SIMD128_VALUE_TYPE: {
+#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
+ if (Is##Type()) { \
+ os << "<" #Type ">"; \
+ break; \
+ }
+ SIMD128_TYPES(SIMD128_TYPE)
+#undef SIMD128_TYPE
+ UNREACHABLE();
break;
+ }
case JS_PROXY_TYPE:
os << "<JSProxy>";
break;
@@ -1569,13 +1559,7 @@ void HeapObject::IterateBody(InstanceType type, int object_size,
case HEAP_NUMBER_TYPE:
case MUTABLE_HEAP_NUMBER_TYPE:
- case FLOAT32X4_TYPE:
- case INT32X4_TYPE:
- case BOOL32X4_TYPE:
- case INT16X8_TYPE:
- case BOOL16X8_TYPE:
- case INT8X16_TYPE:
- case BOOL8X16_TYPE:
+ case SIMD128_VALUE_TYPE:
case FILLER_TYPE:
case BYTE_ARRAY_TYPE:
case BYTECODE_ARRAY_TYPE:
« no previous file with comments | « src/objects.h ('k') | src/objects-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698