Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: src/objects-printer.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-simd.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index 82648e1352e7f111e7fbd9a35ac3efb329effd16..54518a21ff619506889e45c32370329cf19a9053 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -60,26 +60,8 @@ void HeapObject::HeapObjectPrint(std::ostream& os) { // NOLINT
HeapNumber::cast(this)->HeapNumberPrint(os);
os << ">";
break;
- case FLOAT32X4_TYPE:
- Float32x4::cast(this)->Float32x4Print(os);
- break;
- case INT32X4_TYPE:
- Int32x4::cast(this)->Int32x4Print(os);
- break;
- case BOOL32X4_TYPE:
- Bool32x4::cast(this)->Bool32x4Print(os);
- break;
- case INT16X8_TYPE:
- Int16x8::cast(this)->Int16x8Print(os);
- break;
- case BOOL16X8_TYPE:
- Bool16x8::cast(this)->Bool16x8Print(os);
- break;
- case INT8X16_TYPE:
- Int16x8::cast(this)->Int16x8Print(os);
- break;
- case BOOL8X16_TYPE:
- Bool16x8::cast(this)->Bool16x8Print(os);
+ case SIMD128_VALUE_TYPE:
+ Simd128Value::cast(this)->Simd128ValuePrint(os);
break;
case FIXED_DOUBLE_ARRAY_TYPE:
FixedDoubleArray::cast(this)->FixedDoubleArrayPrint(os);
@@ -209,6 +191,15 @@ void HeapObject::HeapObjectPrint(std::ostream& os) { // NOLINT
}
+void Simd128Value::Simd128ValuePrint(std::ostream& os) { // NOLINT
+#define PRINT_SIMD128_VALUE(TYPE, Type, type, lane_count, lane_type) \
+ if (Is##Type()) return Type::cast(this)->Type##Print(os);
+ SIMD128_TYPES(PRINT_SIMD128_VALUE)
+#undef PRINT_SIMD128_VALUE
+ UNREACHABLE();
+}
+
+
void Float32x4::Float32x4Print(std::ostream& os) { // NOLINT
char arr[100];
Vector<char> buffer(arr, arraysize(arr));
« no previous file with comments | « src/objects-inl.h ('k') | src/runtime/runtime-simd.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698