Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: src/hydrogen-instructions.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index 2e9475542b8b56e5c7c6c54e4ca83aa578aac380..770d710a3acec403cd0227f39cb21fcd5c8db737 100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -1326,20 +1326,17 @@ static String* TypeOfString(HConstant* constant, Isolate* isolate) {
}
case SYMBOL_TYPE:
return heap->symbol_string();
- case FLOAT32X4_TYPE:
- return heap->float32x4_string();
- case INT32X4_TYPE:
- return heap->int32x4_string();
- case BOOL32X4_TYPE:
- return heap->bool32x4_string();
- case INT16X8_TYPE:
- return heap->int16x8_string();
- case BOOL16X8_TYPE:
- return heap->bool16x8_string();
- case INT8X16_TYPE:
- return heap->int8x16_string();
- case BOOL8X16_TYPE:
- return heap->bool8x16_string();
+ case SIMD128_VALUE_TYPE: {
+ Unique<Map> map = constant->ObjectMap();
+#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
+ if (map.IsKnownGlobal(heap->type##_map())) { \
+ return heap->type##_string(); \
+ }
+ SIMD128_TYPES(SIMD128_TYPE)
+#undef SIMD128_TYPE
+ UNREACHABLE();
+ return nullptr;
+ }
case JS_FUNCTION_TYPE:
case JS_FUNCTION_PROXY_TYPE:
return heap->function_string();
« no previous file with comments | « src/hydrogen.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698