Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1273353003: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix slow check failures. REBASE. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/ia32/full-codegen-ia32.cc
diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc
index d9ca3bd0c4d74bbf5141997438d4a7420ae99838..0ddae8a8f8ecae09d870528875d163c4016de3c5 100644
--- a/src/full-codegen/ia32/full-codegen-ia32.cc
+++ b/src/full-codegen/ia32/full-codegen-ia32.cc
@@ -3333,13 +3333,9 @@ void FullCodeGenerator::EmitIsSimdValue(CallRuntime* expr) {
&if_false, &fall_through);
__ JumpIfSmi(eax, if_false);
- Register map = ebx;
- __ mov(map, FieldOperand(eax, HeapObject::kMapOffset));
- __ CmpInstanceType(map, FIRST_SIMD_VALUE_TYPE);
- __ j(less, if_false);
- __ CmpInstanceType(map, LAST_SIMD_VALUE_TYPE);
+ __ CmpObjectType(eax, SIMD128_VALUE_TYPE, ebx);
PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
- Split(less_equal, if_true, if_false, fall_through);
+ Split(equal, if_true, if_false, fall_through);
context()->Plug(if_true, if_false);
}
@@ -4985,34 +4981,6 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
__ JumpIfSmi(eax, if_false);
__ CmpObjectType(eax, SYMBOL_TYPE, edx);
Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->float32x4_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, FLOAT32X4_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int32x4_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, INT32X4_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool32x4_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, BOOL32X4_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int16x8_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, INT16X8_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool16x8_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, BOOL16X8_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->int8x16_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, INT8X16_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
- } else if (String::Equals(check, factory->bool8x16_string())) {
- __ JumpIfSmi(eax, if_false);
- __ CmpObjectType(eax, BOOL8X16_TYPE, edx);
- Split(equal, if_true, if_false, fall_through);
} else if (String::Equals(check, factory->boolean_string())) {
__ cmp(eax, isolate()->factory()->true_value());
__ j(equal, if_true);
@@ -5046,6 +5014,16 @@ void FullCodeGenerator::EmitLiteralCompareTypeof(Expression* expr,
__ test_b(FieldOperand(edx, Map::kBitFieldOffset),
1 << Map::kIsUndetectable);
Split(zero, if_true, if_false, fall_through);
+// clang-format off
+#define SIMD128_TYPE(TYPE, Type, type, lane_count, lane_type) \
+ } else if (String::Equals(check, factory->type##_string())) { \
+ __ JumpIfSmi(eax, if_false); \
+ __ cmp(FieldOperand(eax, HeapObject::kMapOffset), \
+ isolate()->factory()->type##_map()); \
+ Split(equal, if_true, if_false, fall_through);
+ SIMD128_TYPES(SIMD128_TYPE)
+#undef SIMD128_TYPE
+ // clang-format on
} else {
if (if_false != fall_through) __ jmp(if_false);
}
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698