Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_

Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_
so that rebuilding detail inputs on Autofill popup acceptance doesn't crash.
This also changes the public AutofillDialogView API to accept ServerFieldTypes
intead of DetailInputs in FillSection() and HitTestInput().

NOTE: |input.type| was the only thing used by all callers anyways, so rather than
dance around resetting a potentially dead pointer, I'd rather change to server
types.

BUG=331544
R=estade@chromium.org,groby@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243831

[groby-ooo-7-16, 2014-01-08 17:54:40]

I assume you'll address the other APIs using pointers instead of a type ID in a
later CL?

Cocoa side is LGTM

[Dan Beam, 2014-01-08 22:01:05]

On 2014/01/08 17:54:40, groby wrote:
> I assume you'll address the other APIs using pointers instead of a type ID in
a
> later CL?

yes, right now just doing them as we need them.  many places still use other
parts of detailinputs so making them internal to the controller or removing them
completely will likely never be possible.

> 
> Cocoa side is LGTM

[Evan Stade, 2014-01-08 22:03:47]

lgtm

[commit-bot: I haz the power, 2014-01-08 22:06:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/127153004/1

[commit-bot: I haz the power, 2014-01-09 10:26:49]

Change committed as 243831