Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 459907ccbd3b9f30e0d4d88848dfcf56b1b6a22c..80cd053b47a69d5249095ba5f0078fca5c1cd2f0 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -1316,11 +1316,11 @@ void AutofillDialogViews::UpdateErrorBubble() {
}
void AutofillDialogViews::FillSection(DialogSection section,
- const DetailInput& originating_input) {
+ ServerFieldType originating_type) {
DetailsGroup* group = GroupForSection(section);
// Make sure to overwrite the originating input.
TextfieldMap::iterator text_mapping =
- group->textfields.find(originating_input.type);
+ group->textfields.find(originating_type);
if (text_mapping != group->textfields.end())
text_mapping->second->SetText(base::string16());
@@ -1328,7 +1328,7 @@ void AutofillDialogViews::FillSection(DialogSection section,
// CC comboboxes (even if they already have something in them). If the
// Autofill data comes from an AutofillProfile, leave the comboboxes alone.
if (section == GetCreditCardSection() &&
- AutofillType(originating_input.type).group() == CREDIT_CARD) {
+ AutofillType(originating_type).group() == CREDIT_CARD) {
for (ComboboxMap::const_iterator it = group->comboboxes.begin();
it != group->comboboxes.end(); ++it) {
if (AutofillType(it->first).group() == CREDIT_CARD)
@@ -1358,11 +1358,11 @@ base::string16 AutofillDialogViews::GetCvc() {
decorated_textfield()->text();
}
-bool AutofillDialogViews::HitTestInput(const DetailInput& input,
+bool AutofillDialogViews::HitTestInput(ServerFieldType type,
const gfx::Point& screen_point) {
- views::View* view = TextfieldForType(input.type);
+ views::View* view = TextfieldForType(type);
if (!view)
- view = ComboboxForType(input.type);
+ view = ComboboxForType(type);
if (view) {
gfx::Point target_point(screen_point);
« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698