chrome/browser/ui/cocoa/autofill/autofill_section_container.mm - Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_section_container.h ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

index 31d0bb8178683dcc85fee5c9924045ea032e7c38..2afcb6457131600b41168524196f3f29024d6d98 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

@@ -345,13 +345,13 @@ bool ShouldOverwriteComboboxes(autofill::DialogSection section,

[self updateAndClobber:YES];

}

-- (void)fillForInput:(const autofill::DetailInput&)input {

+- (void)fillForType:(const autofill::ServerFieldType)type {

// Make sure to overwrite the originating input if it is a text field.

AutofillTextField* field =

- base::mac::ObjCCast<AutofillTextField>([inputs_ viewWithTag:input.type]);

+ base::mac::ObjCCast<AutofillTextField>([inputs_ viewWithTag:type]);

[field setFieldValue:@""];

- if (ShouldOverwriteComboboxes(section_, input.type)) {

+ if (ShouldOverwriteComboboxes(section_, type)) {

for (NSControl* control in [inputs_ subviews]) {

AutofillPopUpButton* popup =

base::mac::ObjCCast<AutofillPopUpButton>(control);