Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 5 #ifndef CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 6 #define CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 // Exposed for testing. 234 // Exposed for testing.
235 AutofillDialogControllerImpl( 235 AutofillDialogControllerImpl(
236 content::WebContents* contents, 236 content::WebContents* contents,
237 const FormData& form_structure, 237 const FormData& form_structure,
238 const GURL& source_url, 238 const GURL& source_url,
239 const base::Callback<void(const FormStructure*)>& callback); 239 const base::Callback<void(const FormStructure*)>& callback);
240 240
241 // Exposed for testing. 241 // Exposed for testing.
242 AutofillDialogView* view() { return view_.get(); } 242 AutofillDialogView* view() { return view_.get(); }
243 virtual AutofillDialogView* CreateView(); 243 virtual AutofillDialogView* CreateView();
244 const DetailInput* input_showing_popup() const { 244 ServerFieldType popup_input_type() const {
245 return input_showing_popup_; 245 return popup_input_type_;
246 } 246 }
247 247
248 // Returns the PersonalDataManager for |profile_|. 248 // Returns the PersonalDataManager for |profile_|.
249 virtual PersonalDataManager* GetManager() const; 249 virtual PersonalDataManager* GetManager() const;
250 250
251 // Returns the WalletClient* this class uses to talk to Online Wallet. Exposed 251 // Returns the WalletClient* this class uses to talk to Online Wallet. Exposed
252 // for testing. 252 // for testing.
253 const wallet::WalletClient* GetWalletClient() const; 253 const wallet::WalletClient* GetWalletClient() const;
254 virtual wallet::WalletClient* GetWalletClient(); 254 virtual wallet::WalletClient* GetWalletClient();
255 255
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 // we should show a shipping section. 665 // we should show a shipping section.
666 bool cares_about_shipping_; 666 bool cares_about_shipping_;
667 667
668 // The GUIDs for the currently showing unverified profiles popup. 668 // The GUIDs for the currently showing unverified profiles popup.
669 std::vector<PersonalDataManager::GUIDPair> popup_guids_; 669 std::vector<PersonalDataManager::GUIDPair> popup_guids_;
670 670
671 // The controller for the currently showing popup (which helps users when 671 // The controller for the currently showing popup (which helps users when
672 // they're manually filling the dialog). 672 // they're manually filling the dialog).
673 base::WeakPtr<AutofillPopupControllerImpl> popup_controller_; 673 base::WeakPtr<AutofillPopupControllerImpl> popup_controller_;
674 674
675 // The input for which |popup_controller_| is currently showing a popup 675 // The type of the visible Autofill popup input (or UNKNOWN_TYPE if none).
676 // (if any). 676 ServerFieldType popup_input_type_;
677 const DetailInput* input_showing_popup_;
678 677
679 scoped_ptr<AutofillDialogView> view_; 678 scoped_ptr<AutofillDialogView> view_;
680 679
681 // A NotificationRegistrar for tracking the completion of sign-in. 680 // A NotificationRegistrar for tracking the completion of sign-in.
682 content::NotificationRegistrar signin_registrar_; 681 content::NotificationRegistrar signin_registrar_;
683 682
684 base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_; 683 base::WeakPtrFactory<AutofillDialogControllerImpl> weak_ptr_factory_;
685 684
686 // Set to true when the user presses the sign in link, until we're ready to 685 // Set to true when the user presses the sign in link, until we're ready to
687 // show the normal dialog again. This is used to hide the buttons while 686 // show the normal dialog again. This is used to hide the buttons while
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 757
759 // A username string we display in the card scrambling/generated overlay. 758 // A username string we display in the card scrambling/generated overlay.
760 base::string16 submitted_cardholder_name_; 759 base::string16 submitted_cardholder_name_;
761 760
762 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl); 761 DISALLOW_COPY_AND_ASSIGN(AutofillDialogControllerImpl);
763 }; 762 };
764 763
765 } // namespace autofill 764 } // namespace autofill
766 765
767 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_ 766 #endif // CHROME_BROWSER_UI_AUTOFILL_AUTOFILL_DIALOG_CONTROLLER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698