Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
index ab279d154b6466fb31eb0fe2eb6d97bfe42c921f..14fbef02ac26b2f20579b1d214897beb7effa274 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h
@@ -241,8 +241,8 @@ class AutofillDialogControllerImpl : public AutofillDialogViewDelegate,
// Exposed for testing.
AutofillDialogView* view() { return view_.get(); }
virtual AutofillDialogView* CreateView();
- const DetailInput* input_showing_popup() const {
- return input_showing_popup_;
+ ServerFieldType popup_input_type() const {
+ return popup_input_type_;
}
// Returns the PersonalDataManager for |profile_|.
@@ -672,9 +672,8 @@ class AutofillDialogControllerImpl : public AutofillDialogViewDelegate,
// they're manually filling the dialog).
base::WeakPtr<AutofillPopupControllerImpl> popup_controller_;
- // The input for which |popup_controller_| is currently showing a popup
- // (if any).
- const DetailInput* input_showing_popup_;
+ // The type of the visible Autofill popup input (or UNKNOWN_TYPE if none).
+ ServerFieldType popup_input_type_;
scoped_ptr<AutofillDialogView> view_;

Powered by Google App Engine
This is Rietveld 408576698