chrome/browser/ui/autofill/autofill_dialog_view.h - Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_view.h

Issue 127153004: Change AutofillDialogControllerImpl::input_showing_popup_ -> popup_input_type_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc ('k') | chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_view.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_view.h b/chrome/browser/ui/autofill/autofill_dialog_view.h

index 39ab3be49d527a8e34006c32dca37cc23a036993..d0747693533906846fc4aeb63e67b57803d6f5d9 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_view.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_view.h

@@ -71,7 +71,7 @@ class AutofillDialogView {

// Fills the given section with Autofill data that was triggered by a user

// interaction with |originating_input|.

virtual void FillSection(DialogSection section,

- const DetailInput& originating_input) = 0;

+ ServerFieldType originating_type) = 0;

// Fills |output| with data the user manually input.

virtual void GetUserInput(DialogSection section, FieldValueMap* output) = 0;

@@ -81,8 +81,8 @@ class AutofillDialogView {

// relevant.

virtual base::string16 GetCvc() = 0;

- // Whether or not |point| is within |input|'s bounds.

- virtual bool HitTestInput(const DetailInput& input,

+ // Whether or not |point| is within the bounds of an input of |type|.

+ virtual bool HitTestInput(ServerFieldType type,

const gfx::Point& screen_point) = 0;

// Returns true if new or edited autofill details should be saved.