Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1265923002: Debugger: move implementation to a separate folder. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: move implementation to a separate folder. R=cbruni@chromium.org Committed: https://crrev.com/1667c15e373fd6958e2d70729382d87d91843e52 Cr-Commit-Position: refs/heads/master@{#29951}

Patch Set 1 #

Patch Set 2 : do not reformat #

Patch Set 3 : update include defines #

Patch Set 4 : add missing files #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -14069 lines) Patch
M BUILD.gn View 1 2 3 4 15 chunks +13 lines, -13 lines 0 comments Download
M WATCHLISTS View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/builtins-arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/arm/debug-arm.cc View 1 chunk +0 lines, -161 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/arm64/debug-arm64.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assert-scope.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/background-parsing-task.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/contexts.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/debug.h View 1 chunk +0 lines, -795 lines 0 comments Download
D src/debug.cc View 1 2 3 4 1 chunk +0 lines, -2811 lines 0 comments Download
D src/debug-debugger.js View 1 chunk +0 lines, -2569 lines 0 comments Download
A + src/debug/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/debug/arm/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/arm/debug-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/arm64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/arm64/debug-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/debug.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + src/debug/debug.cc View 1 2 3 4 5 chunks +5 lines, -4 lines 0 comments Download
A + src/debug/debug.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/ia32/debug-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/liveedit.h View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
A + src/debug/liveedit.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + src/debug/liveedit.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/mips/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/mips/debug-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/mips64/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/mips64/debug-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/mirrors.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/ppc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/ppc/debug-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/x64/debug-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + src/debug/x87/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/debug/x87/debug-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -1 line 0 comments Download
D src/ia32/debug-ia32.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/liveedit.h View 1 chunk +0 lines, -372 lines 0 comments Download
D src/liveedit.cc View 1 chunk +0 lines, -2029 lines 0 comments Download
D src/liveedit-debugger.js View 1 chunk +0 lines, -1107 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/mips/debug-mips.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/mips64/debug-mips64.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/mirror-debugger.js View 1 chunk +0 lines, -3026 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/pending-compilation-error-handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/assembler-ppc-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
D src/ppc/debug-ppc.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/property-details.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +1 line, -1 line 0 comments Download
D src/x64/debug-x64.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +1 line, -1 line 0 comments Download
D src/x87/debug-x87.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-ppc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-function-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/debug-function-scopes.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/test-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 19 chunks +15 lines, -15 lines 0 comments Download
M tools/js2c.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Yang
Camillo, please take a look. This CL simply moves things around, updates build files and ...
5 years, 4 months ago (2015-07-30 08:57:24 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265923002/40001
5 years, 4 months ago (2015-07-30 08:58:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265923002/60001
5 years, 4 months ago (2015-07-30 09:20:00 UTC) #5
Camillo Bruni
On 2015/07/30 08:58:43, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 4 months ago (2015-07-30 09:24:24 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-30 10:37:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265923002/80001
5 years, 4 months ago (2015-07-31 10:35:34 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-31 10:35:36 UTC) #13
Jakob Kummerow
rubberstamp LGTM
5 years, 4 months ago (2015-07-31 10:37:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265923002/80001
5 years, 4 months ago (2015-07-31 10:37:43 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-07-31 11:08:02 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 11:08:29 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1667c15e373fd6958e2d70729382d87d91843e52
Cr-Commit-Position: refs/heads/master@{#29951}

Powered by Google App Engine
This is Rietveld 408576698