Inconsistent use of [x] close panel icon

Inconsistent use of [x] close panel icon 
The close button in download pane should be the tab close button asset : tab_close_*.png 
(this was originally reported as part of BUG=173251
). 

By the same logic the same smaller bitmap with red hover background should be used for all infobars 
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all 
platforms (Mac was missed with the previous implementation). 

The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested). 

Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE. 
IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
png files were also renamed.

BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button. 

TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it). 

TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way. 

TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094
). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190431

[varkha, 2013-03-22 15:50:40]

This resubmit of https://codereview.chromium.org/12966002. The diff got mangled
and this is now being submitted as a new patch.

LGTM from Avi for MAC - https://codereview.chromium.org/12966002/#msg3
LGTM from Elliot for GTK - https://codereview.chromium.org/12966002/#msg4

[sky, 2013-03-22 18:08:30]

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:755: <structure type="chrome_scaled_image"
name="IDR_CLOSE_1" file="common/button_close_1_normal.png" />
File name and IDR name should match (same comment for other grd file too.

[varkha, 2013-03-22 18:12:27]

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:755: <structure type="chrome_scaled_image"
name="IDR_CLOSE_1" file="common/button_close_1_normal.png" />
So in this case file="common/close_1_normal.png" or "common/close_1.png" (both
styles seem to be in use)?

[sky, 2013-03-22 19:32:29]

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/12634025/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:755: <structure type="chrome_scaled_image"
name="IDR_CLOSE_1" file="common/button_close_1_normal.png" />
On 2013/03/22 18:12:27, varkha wrote:
> So in this case file="common/close_1_normal.png" or "common/close_1.png" (both
> styles seem to be in use)?
> 

close_1.png

[varkha, 2013-03-22 21:14:22]

_normal removed (in both cases - hope that was desirable).

[sky, 2013-03-22 23:07:28]

LGTM

[commit-bot: I haz the power, 2013-03-22 23:28:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varkha@chromium.org/12634025/2002

[commit-bot: I haz the power, 2013-03-22 23:28:23]

Can't process patch for file
chrome/app/theme/touch_140_percent/common/close_1.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[flackr, 2013-03-25 00:38:57]

https://chromiumcodereview.appspot.com/12634025/diff/2002/chrome/renderer/res...
File chrome/renderer/resources/plugin_placeholders.css (right):

https://chromiumcodereview.appspot.com/12634025/diff/2002/chrome/renderer/res...
chrome/renderer/resources/plugin_placeholders.css:64: 1x,
nit: These all seem like they should fit on one line / less than 80 chars
especially with the shortened filenames.

[varkha, 2013-03-25 13:55:58]

Fixed wrapped lines in css.

https://chromiumcodereview.appspot.com/12634025/diff/2002/chrome/renderer/res...
File chrome/renderer/resources/plugin_placeholders.css (right):

https://chromiumcodereview.appspot.com/12634025/diff/2002/chrome/renderer/res...
chrome/renderer/resources/plugin_placeholders.css:64: 1x,
On 2013/03/25 00:38:57, flackr wrote:
> nit: These all seem like they should fit on one line / less than 80 chars
> especially with the shortened filenames.

Done.

[flackr, 2013-03-25 15:00:10]

https://chromiumcodereview.appspot.com/12634025/diff/14001/chrome/browser/res...
File chrome/browser/resources/options/chromeos/accounts_options_page.css
(right):

https://chromiumcodereview.appspot.com/12634025/diff/14001/chrome/browser/res...
chrome/browser/resources/options/chromeos/accounts_options_page.css:47:
url('../../../../../ui/resources/default_200_percent/close_2.png') 2x);
Sorry I missed these earlier. Here and elsewhere, wrapped lines should be
indented by 4 spaces and if necessary the 1x/2x wrapped to the next line (See
the original source code).

[varkha, 2013-03-25 15:43:59]

Indentation corrected.

https://chromiumcodereview.appspot.com/12634025/diff/14001/chrome/browser/res...
File chrome/browser/resources/options/chromeos/accounts_options_page.css
(right):

https://chromiumcodereview.appspot.com/12634025/diff/14001/chrome/browser/res...
chrome/browser/resources/options/chromeos/accounts_options_page.css:47:
url('../../../../../ui/resources/default_200_percent/close_2.png') 2x);
On 2013/03/25 15:00:10, flackr wrote:
> Sorry I missed these earlier. Here and elsewhere, wrapped lines should be
> indented by 4 spaces and if necessary the 1x/2x wrapped to the next line (See
> the original source code).

Done.

[flackr, 2013-03-25 17:42:01]

LGTM, I can land for you.

[flackr, 2013-03-25 17:42:44]

Committed patchset #5 manually as r190431 (presubmit successful).