Inconsistent use of [x] close panel icon

Inconsistent use of [x] close panel icon
The close button in download pane should be the tab close button asset : tab_close_*.png
   (this was originally reported as part of BUG=173251
).

By the same logic the same smaller bitmap with red hover background should be used for all infobars
such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
platforms (Mac was missed with the previous implementation).

The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).

Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
IDR_TAB_CLOSE was renamed IDR_CLOSE_BAR.
IDR_CLOSE_BAR was renamed IDR_CLOSE_BUBBLE.

BUG=217094
TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.

TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).

TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.

TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094
). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).

[varkha, 2013-03-20 18:22:28]

sky, you have looked at the part of it when reviewing BUG=173251. The change
mushroomed a bit to make sure we only change the resources that sgabriel
confirmed (infobars everywhere and find-in-page on Mac) and leave close buttons
in bubbles everywhere as they were.

[sky, 2013-03-20 21:10:37]

I'm also adding erg Elliot for gtk and Avi for Mac.

https://codereview.chromium.org/12966002/diff/1/ui/resources/ui_resources.grd
File ui/resources/ui_resources.grd (right):

https://codereview.chromium.org/12966002/diff/1/ui/resources/ui_resources.grd...
ui/resources/ui_resources.grd:135: <structure type="chrome_scaled_image"
name="IDR_CLOSE_BUBBLE" file="close_bar.png" />
Can you rename the files to match.

Also, the use of _BAR or _BUBBLE isn't always clear. For example, why is a tab
or balloon considered a bar? I think I would rather have something more
nebulous, say CLOSE1 and CLOSE2.

[Avi (use Gerrit), 2013-03-20 21:17:20]

The Mac changes are trivial and lgtm. Scott raises good questions; make sure he
ends up happy.

[Elliot Glaysher, 2013-03-20 21:25:15]

the gtk changes, while spread over a bunch of files, are also trivial. It
doesn't look like this changes the native theme behaviour, so lgtm.

[varkha1, 2013-03-20 21:31:32]

Will rename the PNG's. Would CLOSE_BLACK / CLOSE_RED be better than
non-descriptive CLOSE1 / CLOSE2? I could do CLOSE_RED_HOVER vs.
CLOSE_TRANSPARENT - that describes the assets themselves and not their use,
I think this is what you want.

  >> balloon considered a bar...
I thought I considered a balloon to be a bubble, but I see your point about
the tab - it is not really a bar, just happens to be using the same close
button.


On Wed, Mar 20, 2013 at 5:25 PM, <erg@chromium.org> wrote:

> the gtk changes, while spread over a bunch of files, are also trivial. It
> doesn't look like this changes the native theme behaviour, so lgtm.
>
>
https://codereview.chromium.**org/12966002/<https://codereview.chromium.org/1...
>

[sky, 2013-03-20 22:07:50]

I like 1 and 2 over black/red.


On Wed, Mar 20, 2013 at 2:31 PM, Valery Arkhangorodsky
<varkha@google.com>wrote:

> Will rename the PNG's. Would CLOSE_BLACK / CLOSE_RED be better than
> non-descriptive CLOSE1 / CLOSE2? I could do CLOSE_RED_HOVER vs.
> CLOSE_TRANSPARENT - that describes the assets themselves and not their use,
> I think this is what you want.
>
>   >> balloon considered a bar...
> I thought I considered a balloon to be a bubble, but I see your point
> about the tab - it is not really a bar, just happens to be using the same
> close button.
>
>
> On Wed, Mar 20, 2013 at 5:25 PM, <erg@chromium.org> wrote:
>
>> the gtk changes, while spread over a bunch of files, are also trivial. It
>> doesn't look like this changes the native theme behaviour, so lgtm.
>>
>>
https://codereview.chromium.**org/12966002/<https://codereview.chromium.org/1...
>>
>
>

[sky, 2013-03-20 22:19:38]

One reason I don't like using the color in the name is that I can guarantee we
will change the colors in the future, making those names meaningless.

[tfarina, 2013-03-20 22:38:27]

On Wednesday, March 20, 2013, wrote:

> One reason I don't like using the color in the name is that I can
> guarantee we
> will change the colors in the future, making those names meaningless.
>
> CLOSE_NORMAL and CLOSE_HOVER so?

1 and 2 will make it hard to know what they are for.


>
https://codereview.chromium.**org/12966002/<https://codereview.chromium.org/1...
>


-- 
Thiago

[varkha, 2013-03-21 23:38:45]

I have uploaded the set with the resources renamed ("1" and "2") variant. sky,
would this be OK or you would like me to change it to some description that does
not involve color, say (*_TRANSPARENT and *_ACCENTED)? Also the png's names are
getting longish, so I would like to truncate them if 1/2 are not accepted.

[sky, 2013-03-22 04:07:38]

Your diff didn't seem to make it, could you try again?

I like 1 and 2 since there isn't really a good description to use here. It's
basically two sets of similar close resources that vary based on the current
design. I don't see a good way to capture that in a textual description.

[varkha, 2013-03-22 04:11:45]

Could it be because I used SVC for the first and git for the second? I can see
the changes and generate diffs but not in side by side view.

[varkha, 2013-03-22 15:51:52]

This has been superseded by https://codereview.chromium.org/12634025/ due to
mangled diffs.