chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Fixed compile on linux, mac and win Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc b/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc

index 6b656f34a6cb4fc04f484a0217dd91f8233a80ee..5e840de0db9f65c17d7f84d39f9aa6246c88c14e 100644

--- a/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc

@@ -153,7 +153,7 @@ void OneClickSigninBubbleGtk::InitializeWidgets(

pango_attr_weight_new(PANGO_WEIGHT_BOLD));

gtk_label_set_attributes(GTK_LABEL(header_label_), attributes);

pango_attr_list_unref(attributes);

- close_button_.reset(CustomDrawButton::CloseButton(theme_provider));

+ close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_provider));

g_signal_connect(close_button_->widget(), "clicked",

G_CALLBACK(OnClickCloseButtonThunk), this);

}