Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(8)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/app/theme/touch_100_percent/common/close_1.png
Issue
12634025
:
Inconsistent use of [x] close panel icon (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251
Patch Set: Fixed compile on linux, mac and win
Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
build/ios/grit_whitelist.txt
chrome/app/theme/default_100_percent/common/close_1.png
chrome/app/theme/default_100_percent/common/close_1_hover.png
chrome/app/theme/default_100_percent/common/close_1_mask.png
chrome/app/theme/default_100_percent/common/close_1_pressed.png
chrome/app/theme/default_100_percent/common/tab_close_hover.png
chrome/app/theme/default_100_percent/common/tab_close_mask.png
chrome/app/theme/default_100_percent/common/tab_close_normal.png
chrome/app/theme/default_100_percent/common/tab_close_pressed.png
chrome/app/theme/default_200_percent/common/close_1.png
chrome/app/theme/default_200_percent/common/close_1_hover.png
chrome/app/theme/default_200_percent/common/close_1_mask.png
chrome/app/theme/default_200_percent/common/close_1_pressed.png
chrome/app/theme/default_200_percent/common/tab_close_hover.png
chrome/app/theme/default_200_percent/common/tab_close_mask.png
chrome/app/theme/default_200_percent/common/tab_close_normal.png
chrome/app/theme/default_200_percent/common/tab_close_pressed.png
chrome/app/theme/theme_resources.grd
chrome/app/theme/touch_100_percent/common/close_1.png
chrome/app/theme/touch_100_percent/common/close_1_hover.png
chrome/app/theme/touch_100_percent/common/close_1_mask.png
chrome/app/theme/touch_100_percent/common/close_1_pressed.png
chrome/app/theme/touch_100_percent/common/tab_close_hover.png
chrome/app/theme/touch_100_percent/common/tab_close_mask.png
chrome/app/theme/touch_100_percent/common/tab_close_normal.png
chrome/app/theme/touch_100_percent/common/tab_close_pressed.png
chrome/app/theme/touch_140_percent/common/close_1.png
chrome/app/theme/touch_140_percent/common/close_1_hover.png
chrome/app/theme/touch_140_percent/common/close_1_mask.png
chrome/app/theme/touch_140_percent/common/close_1_pressed.png
chrome/app/theme/touch_140_percent/common/tab_close_hover.png
chrome/app/theme/touch_140_percent/common/tab_close_mask.png
chrome/app/theme/touch_140_percent/common/tab_close_normal.png
chrome/app/theme/touch_140_percent/common/tab_close_pressed.png
chrome/app/theme/touch_180_percent/common/close_1.png
chrome/app/theme/touch_180_percent/common/close_1_hover.png
chrome/app/theme/touch_180_percent/common/close_1_mask.png
chrome/app/theme/touch_180_percent/common/close_1_pressed.png
chrome/app/theme/touch_180_percent/common/tab_close_hover.png
chrome/app/theme/touch_180_percent/common/tab_close_mask.png
chrome/app/theme/touch_180_percent/common/tab_close_normal.png
chrome/app/theme/touch_180_percent/common/tab_close_pressed.png
chrome/browser/first_run/try_chrome_dialog_view.cc
chrome/browser/resources/ntp4/new_tab.css
chrome/browser/resources/options/chromeos/accounts_options_page.css
chrome/browser/resources/options/options_page.css
chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
chrome/browser/ui/cocoa/hover_close_button.mm
chrome/browser/ui/cocoa/infobars/infobar_controller.mm
chrome/browser/ui/gtk/confirm_bubble_gtk.cc
chrome/browser/ui/gtk/custom_button.h
chrome/browser/ui/gtk/custom_button.cc
chrome/browser/ui/gtk/download/download_shelf_gtk.cc
chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc
chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc
chrome/browser/ui/gtk/find_bar_gtk.cc
chrome/browser/ui/gtk/infobars/infobar_gtk.cc
chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc
chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc
chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc
chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc
chrome/browser/ui/views/download/download_shelf_view.cc
chrome/browser/ui/views/extensions/bundle_installed_bubble.cc
chrome/browser/ui/views/extensions/extension_installed_bubble.cc
chrome/browser/ui/views/find_bar_view.cc
chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc
chrome/browser/ui/views/infobars/infobar_view.cc
chrome/browser/ui/views/notifications/balloon_view_views.cc
chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc
chrome/browser/ui/views/tabs/tab.cc
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
chrome/renderer/resources/plugin_placeholders.css
ui/resources/default_100_percent/close_2.png
ui/resources/default_100_percent/close_2_hover.png
ui/resources/default_100_percent/close_2_mask.png
ui/resources/default_100_percent/close_2_pressed.png
ui/resources/default_100_percent/close_bar.png
ui/resources/default_100_percent/close_bar_hover.png
ui/resources/default_100_percent/close_bar_mask.png
ui/resources/default_100_percent/close_bar_pressed.png
ui/resources/default_200_percent/close_2.png
ui/resources/default_200_percent/close_2_hover.png
ui/resources/default_200_percent/close_2_mask.png
ui/resources/default_200_percent/close_2_pressed.png
ui/resources/default_200_percent/close_bar.png
ui/resources/default_200_percent/close_bar_hover.png
ui/resources/default_200_percent/close_bar_mask.png
ui/resources/default_200_percent/close_bar_pressed.png
ui/resources/ui_resources.grd
ui/webui/resources/css/bubble.css
ui/webui/resources/css/expandable_bubble.css
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/app/theme/theme_resources.grd
('k') |
chrome/app/theme/touch_100_percent/common/close_1_hover.png »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« no previous file with comments
|
« chrome/app/theme/theme_resources.grd
('k') |
chrome/app/theme/touch_100_percent/common/close_1_hover.png »
('j') |
no next file with comments »
Issue 12634025: Inconsistent use of [x] close panel icon (Closed)
Created 7 years, 9 months ago by varkha
Modified 7 years, 9 months ago
Reviewers: sky, flackr
Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251
Comments: 7
This is Rietveld
408576698
Chromium Code Reviews
Issue 12634025:
Inconsistent use of [x] close panel icon (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251
