chrome/browser/ui/gtk/confirm_bubble_gtk.cc - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/confirm_bubble_gtk.cc

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Fixed compile on linux, mac and win Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/confirm_bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/confirm_bubble_gtk.cc b/chrome/browser/ui/gtk/confirm_bubble_gtk.cc

index 782276777f581ccd6f9c9f81ea328469486e9b49..c00463d3e3d3ad2c8263fef328b450bcaee2e282 100644

--- a/chrome/browser/ui/gtk/confirm_bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/confirm_bubble_gtk.cc

@@ -81,7 +81,7 @@ void ConfirmBubbleGtk::Show() {

gtk_box_pack_start(GTK_BOX(row), title_label, FALSE, FALSE, 0);

gtk_box_pack_start(GTK_BOX(row), gtk_label_new(NULL), TRUE, TRUE, 0);

- close_button_.reset(CustomDrawButton::CloseButton(theme_service));

+ close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_service));

g_signal_connect(close_button_->widget(), "clicked",

G_CALLBACK(OnCloseButtonThunk), this);

gtk_box_pack_end(GTK_BOX(row), close_button_->widget(), FALSE, FALSE, 0);