chrome/browser/ui/cocoa/hover_close_button.mm - Issue 12634025: Inconsistent use of [x] close panel icon

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/hover_close_button.mm

Issue 12634025: Inconsistent use of [x] close panel icon (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_173251

Patch Set: Fixed compile on linux, mac and win Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/hover_close_button.mm

diff --git a/chrome/browser/ui/cocoa/hover_close_button.mm b/chrome/browser/ui/cocoa/hover_close_button.mm

index 374500b942c20a865a332dbfd4fafbf36e3dbea5..3c2a9523a1ae09e5405fa9887749fe3052c8524a 100644

--- a/chrome/browser/ui/cocoa/hover_close_button.mm

+++ b/chrome/browser/ui/cocoa/hover_close_button.mm

@@ -160,16 +160,16 @@ NSString* const kFadeOutValueKeyPath = @"fadeOutValue";

}

- (NSImage*)imageForHoverState:(HoverState)hoverState {

- int imageID = IDR_TAB_CLOSE;

+ int imageID = IDR_CLOSE_1;

switch (hoverState) {

case kHoverStateNone:

- imageID = IDR_TAB_CLOSE;

+ imageID = IDR_CLOSE_1;

break;

case kHoverStateMouseOver:

- imageID = IDR_TAB_CLOSE_H;

+ imageID = IDR_CLOSE_1_H;

break;

case kHoverStateMouseDown:

- imageID = IDR_TAB_CLOSE_P;

+ imageID = IDR_CLOSE_1_P;

break;

}

ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();