Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed)

Created:
5 years, 4 months ago by Dirk Pranke
Modified:
5 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, binji+watch_chromium.org, bradnelson+warch_chromium.org, browser-components-watch_chromium.org, teravest+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, ihf+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-notifications_chromium.org, rickyz+watch_chromium.org, feature-media-reviews_chromium.org, kalyank, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, peter+watch_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, yurys, plaree+watch_chromium.org, tfarina, estade+watch_chromium.org, cc-bugs_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add precompiled headers to GN build for large targets." This reverts commit 8f3218985dde74063ccc362da47803be163f3165. It looks like this may have broken incremental builds on Win. TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7ba63a918a644773af77dc657792d6440e8afbc1 Cr-Commit-Position: refs/heads/master@{#340620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -187 lines) Patch
M ash/BUILD.gn View 3 chunks +1 line, -4 lines 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M base/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M build/json_schema_api.gni View 2 chunks +0 lines, -6 lines 0 comments Download
M build/precompile.h View 3 chunks +69 lines, -17 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M cc/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +1 line, -7 lines 0 comments Download
M extensions/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M extensions/common/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/BUILD.gn View 3 chunks +6 lines, -18 lines 0 comments Download
M ppapi/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/win/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/views/BUILD.gn View 2 chunks +2 lines, -8 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 4 months ago (2015-07-28 00:53:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1256223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1256223003/1
5 years, 4 months ago (2015-07-28 00:54:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-28 00:55:32 UTC) #4
Dirk Pranke
Sample failure: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/4709
5 years, 4 months ago (2015-07-28 00:55:42 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 00:56:49 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7ba63a918a644773af77dc657792d6440e8afbc1
Cr-Commit-Position: refs/heads/master@{#340620}

Powered by Google App Engine
This is Rietveld 408576698