build/config/compiler/BUILD.gn - Issue 1256223003: Revert "Add precompiled headers to GN build for large targets."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 871abf25aacf80bfd449df1ec9caa7bf0e84828b..86d1586fda41599c534ebc97d284d44e87c53053 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -108,12 +108,6 @@ config("compiler") {

"/FS", # Preserve previous PDB behavior.

]

- # Force C/C++ mode for the given GN detected file type. This is necessary

- # for precompiled headers where the same source file is compiled in both

- # modes.

- cflags_c += [ "/TC" ]

- cflags_cc += [ "/TP" ]

# Building with Clang on Windows is a work in progress and very

# experimental. See crbug.com/82385.

# Keep this in sync with the similar block in build/common.gypi

« no previous file with comments | « build/config/BUILD.gn ('k') | build/json_schema_api.gni » ('j') | no next file with comments »