ui/views/BUILD.gn - Issue 1256223003: Revert "Add precompiled headers to GN build for large targets."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/BUILD.gn

diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn

index ae64118d03f8e1bc2cb8269b81101268952474f8..c14f0892d9f345f1f9de1bae2edde2de4f339206 100644

--- a/ui/views/BUILD.gn

+++ b/ui/views/BUILD.gn

@@ -19,12 +19,8 @@ component("views") {

all_dependent_configs = [ ":flags" ]

sources = gypi_values.views_sources

- configs += [

- "//build/config:precompiled_headers",

- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

- "//build/config/compiler:no_size_t_to_int_warning",

- ]

+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

defines = [ "VIEWS_IMPLEMENTATION" ]

@@ -142,8 +138,6 @@ static_library("test_support") {

testonly = true

sources = gypi_values.views_test_support_sources

- configs += [ "//build/config:precompiled_headers" ]

public_deps = [

":views",

]

« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/wm/BUILD.gn » ('j') | no next file with comments »