Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Side by Side Diff: build/config/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/BUILD.gn ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/allocator.gni") 5 import("//build/config/allocator.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/crypto.gni") 7 import("//build/config/crypto.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/sanitizers/sanitizers.gni") 9 import("//build/config/sanitizers/sanitizers.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 # Add this config to your target to enable precompiled headers. 411 # Add this config to your target to enable precompiled headers.
412 # 412 #
413 # On Windows, precompiled headers are done on a per-target basis. If you have 413 # On Windows, precompiled headers are done on a per-target basis. If you have
414 # just a couple of files, the time it takes to precompile (~2 seconds) can 414 # just a couple of files, the time it takes to precompile (~2 seconds) can
415 # actually be longer than the time saved. On a Z620, a 100 file target compiles 415 # actually be longer than the time saved. On a Z620, a 100 file target compiles
416 # about 2 seconds faster with precompiled headers, with greater savings for 416 # about 2 seconds faster with precompiled headers, with greater savings for
417 # larger targets. 417 # larger targets.
418 # 418 #
419 # Recommend precompiled headers for targets with more than 50 .cc files. 419 # Recommend precompiled headers for targets with more than 50 .cc files.
420 config("precompiled_headers") { 420 config("precompiled_headers") {
421 if (is_win) { 421 # TODO(brettw) enable this when GN support in the binary has been rolled.
422 #if (is_win) {
423 if (false) {
422 # This is a string rather than a file GN knows about. It has to match 424 # This is a string rather than a file GN knows about. It has to match
423 # exactly what's in the /FI flag below, and what might appear in the source 425 # exactly what's in the /FI flag below, and what might appear in the source
424 # code in quotes for an #include directive. 426 # code in quotes for an #include directive.
425 precompiled_header = "build/precompile.h" 427 precompiled_header = "build/precompile.h"
426 428
427 # This is a file that GN will compile with the above header. It will be 429 # This is a file that GN will compile with the above header. It will be
428 # implicitly added to the sources (potentially multiple times, with one 430 # implicitly added to the sources (potentially multiple times, with one
429 # variant for each language used in the target). 431 # variant for each language used in the target).
430 precompiled_source = "//build/precompile.cc" 432 precompiled_source = "//build/precompile.cc"
431 433
432 # Force include the header. 434 # Force include the header.
433 cflags = [ "/FI$precompiled_header" ] 435 cflags = [ "/FI$precompiled_header" ]
434 } 436 }
435 } 437 }
OLDNEW
« no previous file with comments | « base/test/BUILD.gn ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698