Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/precompile.h ('k') | cc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/BUILD.gn
diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn
index 1ac362336ea783d69da3a6f0b012f4a69f073e84..454cddea4f53249c775e17e62900a0f0a990e107 100644
--- a/build/toolchain/win/BUILD.gn
+++ b/build/toolchain/win/BUILD.gn
@@ -80,7 +80,9 @@ template("msvc_toolchain") {
tool("cc") {
rspfile = "{{output}}.rsp"
- precompiled_header_type = "msvc"
+
+ # TODO(brettw) enable this when GN support in the binary has been rolled.
+ #precompiled_header_type = "msvc"
pdbname = "{{target_out_dir}}/{{target_output_name}}_c.pdb"
command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd$pdbname"
depsformat = "msvc"
@@ -93,7 +95,9 @@ template("msvc_toolchain") {
tool("cxx") {
rspfile = "{{output}}.rsp"
- precompiled_header_type = "msvc"
+
+ # TODO(brettw) enable this when GN support in the binary has been rolled.
+ #precompiled_header_type = "msvc"
# The PDB name needs to be different between C and C++ compiled files.
pdbname = "{{target_out_dir}}/{{target_output_name}}_cc.pdb"
« no previous file with comments | « build/precompile.h ('k') | cc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698