Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/common/extensions/api/BUILD.gn

Issue 1256223003: Revert "Add precompiled headers to GN build for large targets." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/json_schema_api.gni") 5 import("//build/json_schema_api.gni")
6 import("schemas.gni") 6 import("schemas.gni")
7 7
8 assert(enable_extensions) 8 assert(enable_extensions)
9 9
10 # GYP version: chrome/common/extensions/api/api.gyp:chrome_api 10 # GYP version: chrome/common/extensions/api/api.gyp:chrome_api
11 json_schema_api("api") { 11 json_schema_api("api") {
12 schemas = true 12 schemas = true
13 bundle = true 13 bundle = true
14 configs = [ "//build/config:precompiled_headers" ]
15 bundle_name = "Chrome" 14 bundle_name = "Chrome"
16 15
17 deps = schema_dependencies 16 deps = schema_dependencies
18 } 17 }
19 18
20 # GYP version: chrome/browser/extensions/api/api.gyp:chrome_api_registration 19 # GYP version: chrome/browser/extensions/api/api.gyp:chrome_api_registration
21 json_schema_api("api_registration") { 20 json_schema_api("api_registration") {
22 impl_dir = "//chrome/browser/extensions/api" 21 impl_dir = "//chrome/browser/extensions/api"
23 bundle_registration = true 22 bundle_registration = true
24 configs = [ "//build/config:precompiled_headers" ]
25 bundle_name = "Chrome" 23 bundle_name = "Chrome"
26 24
27 deps = [ 25 deps = [
28 # Different APIs include headers from these targets. 26 # Different APIs include headers from these targets.
29 "//content/public/browser", 27 "//content/public/browser",
30 "//extensions/browser", 28 "//extensions/browser",
31 29
32 # Different APIs include some headers from chrome/common that in turn 30 # Different APIs include some headers from chrome/common that in turn
33 # include generated headers from these targets. 31 # include generated headers from these targets.
34 # TODO(brettw) this should be made unnecessary if possible. 32 # TODO(brettw) this should be made unnecessary if possible.
35 ":api", 33 ":api",
36 "//components/copresence/proto", 34 "//components/copresence/proto",
37 "//components/metrics/proto", 35 "//components/metrics/proto",
38 "//skia", 36 "//skia",
39 "//sync", 37 "//sync",
40 "//ui/accessibility:ax_gen", 38 "//ui/accessibility:ax_gen",
41 ] 39 ]
42 if (is_chromeos) { 40 if (is_chromeos) {
43 # deps += [ "<(DEPTH)/chrome/chrome.gyp:drive_proto" ] TODO(GYP) 41 # deps += [ "<(DEPTH)/chrome/chrome.gyp:drive_proto" ] TODO(GYP)
44 } 42 }
45 deps += schema_dependencies 43 deps += schema_dependencies
46 44
47 # This must be a static library because the generated schemas have 45 # This must be a static library because the generated schemas have
48 # dependencies into both the browser and child processes, and this won't link 46 # dependencies into both the browser and child processes, and this won't link
49 # in the multi DLL build. In the child DLL, only some files are needed, and 47 # in the multi DLL build. In the child DLL, only some files are needed, and
50 # these have no dependencies into the browser, so a static library solves the 48 # these have no dependencies into the browser, so a static library solves the
51 # problem. 49 # problem.
52 generate_static_library = true 50 generate_static_library = true
53 } 51 }
OLDNEW
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698