Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed)

Created:
7 years, 9 months ago by kasperl
Modified:
7 years, 9 months ago
Reviewers:
karlklose, ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix warnings in dart2js code and re-enable analyzer coverage. R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19545

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add workaround for issue 8802. #

Patch Set 3 : Address review comments. #

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 9 months ago (2013-03-06 09:43:09 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/12513006/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart File sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart (right): https://codereview.chromium.org/12513006/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart#newcode393 sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart:393: sb.write('${holder.name.slowToString()}.${check.name.slowToString()}, '); Long line. https://codereview.chromium.org/12513006/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): ...
7 years, 9 months ago (2013-03-06 09:48:21 UTC) #2
kasperl
Committed patchset #3 manually as r19545 (presubmit successful).
7 years, 9 months ago (2013-03-06 09:53:21 UTC) #3
ngeoffray
7 years, 9 months ago (2013-03-06 11:41:16 UTC) #4
Message was sent while issue was closed.
LGTM! Thanks for adding the test back.

Powered by Google App Engine
This is Rietveld 408576698