Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of ssa; 5 part of ssa;
6 6
7 class SsaCodeGeneratorTask extends CompilerTask { 7 class SsaCodeGeneratorTask extends CompilerTask {
8 8
9 final JavaScriptBackend backend; 9 final JavaScriptBackend backend;
10 10
(...skipping 2606 matching lines...) Expand 10 before | Expand all | Expand 10 after
2617 2617
2618 SsaUnoptimizedCodeGenerator(backend, work) 2618 SsaUnoptimizedCodeGenerator(backend, work)
2619 : super(backend, work), 2619 : super(backend, work),
2620 oldBailoutSwitches = <js.Switch>[], 2620 oldBailoutSwitches = <js.Switch>[],
2621 newParameters = <js.Parameter>[], 2621 newParameters = <js.Parameter>[],
2622 labels = <String>[], 2622 labels = <String>[],
2623 defaultClauseUsedInBailoutStack = <bool>[]; 2623 defaultClauseUsedInBailoutStack = <bool>[];
2624 2624
2625 String pushLabel() { 2625 String pushLabel() {
2626 String label = 'L${labelId++}'; 2626 String label = 'L${labelId++}';
2627 labels.addLast(label); 2627 labels.add(label);
2628 return label; 2628 return label;
2629 } 2629 }
2630 2630
2631 String popLabel() { 2631 String popLabel() {
2632 return labels.removeLast(); 2632 return labels.removeLast();
2633 } 2633 }
2634 2634
2635 String currentLabel() { 2635 String currentLabel() {
2636 return labels.last; 2636 return labels.last;
2637 } 2637 }
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2965 if (leftType.canBeNull() && rightType.canBeNull()) { 2965 if (leftType.canBeNull() && rightType.canBeNull()) {
2966 if (left.isConstantNull() || right.isConstantNull() || 2966 if (left.isConstantNull() || right.isConstantNull() ||
2967 (leftType.isPrimitive() && leftType == rightType)) { 2967 (leftType.isPrimitive() && leftType == rightType)) {
2968 return '=='; 2968 return '==';
2969 } 2969 }
2970 return null; 2970 return null;
2971 } else { 2971 } else {
2972 return '==='; 2972 return '===';
2973 } 2973 }
2974 } 2974 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698