sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart - Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 12513006: Fix warnings in dart2js code and re-enable analyzer coverage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/bailout.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

index 67234b64321795954bbdd6ec2173d651fdf11333..859d65fabcdaa0bd05e04a83fc88b5a94aaf6ec6 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

@@ -390,7 +390,8 @@ class TypeCheckMapping implements TypeChecks {

StringBuffer sb = new StringBuffer();

for (ClassElement holder in this) {

for (ClassElement check in [holder]) {

- sb.add('${holder.name.slowToString()}.${check.name.slowToString()}, ');

+ sb.write('${holder.name.slowToString()}.'

+ '${check.name.slowToString()}, ');

}

return '[$sb]';